File: Use Case Get Available Dataset File Categories #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
FY26 Sprint 2
This reverts commit d492fea.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new use case to retrieve available file categories for a dataset, which supports the JSF feature for populating category dropdown lists when editing file tags. The categories include both default categories and custom categories from other files in the same dataset.
- Adds
GetDatasetAvailableCategoriesuse case and repository method - Updates documentation links for existing file metadata update use cases
- Removes deprecated
LinkDataverseandLinkDatasetpermissions from role definitions
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/datasets/domain/useCases/GetDatasetAvailableCategories.ts |
Implements new use case to retrieve available file categories for a dataset |
src/datasets/infra/repositories/DatasetsRepository.ts |
Adds repository method to fetch available categories from API endpoint |
src/datasets/domain/repositories/IDatasetsRepository.ts |
Adds interface method for getting dataset available categories |
src/datasets/index.ts |
Exports the new use case for public consumption |
test/integration/datasets/DatasetsRepository.test.ts |
Adds integration tests for the new repository method |
test/functional/datasets/GetDatasetAvailableCategories.test.ts |
Adds functional tests for the new use case |
docs/useCases.md |
Documents the new use case with usage examples |
src/files/domain/useCases/UpdateFileTabularTags.ts |
Fixes documentation URL fragment for tabular tags |
src/files/domain/useCases/UpdateFileCategories.ts |
Fixes documentation URL fragment for file categories |
test/testHelpers/roles/roleHelper.ts |
Removes deprecated link permissions from role definitions |
Co-authored-by: Copilot <[email protected]>
…s' of https://github.com/IQSS/dataverse-client-javascript into 336-file-use-cases-get-available-dataset-file-categories
g-saracca
requested changes
Jul 30, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Looks good, just one comment.
g-saracca
previously approved these changes
Jul 31, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
hello! can you resolve the conflicts please :) |
g-saracca
approved these changes
Aug 15, 2025
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
All yours @ofahimIQSS |
Contributor
|
looks good - merging |
ofahimIQSS
deleted the
336-file-use-cases-get-available-dataset-file-categories
branch
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In JSF, when we update Tags -> Edit Tags, there is a list of available categories populated from the dropdown lists, and some of them could be customized categories from other files in the same dataset.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
RoleHelper for testing changed because Revert "feat: "Link Dataset/Dataverse" permission"
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Additional documentation: