File Edit Tags: populate the categories dropdown with results #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
FY26 Sprint 2
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
g-saracca
requested changes
Aug 6, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Looking really good, just some comments.
src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts
Outdated
Show resolved
Hide resolved
...ion-buttons/edit-file-menu/edit-file-tags/edit-file-tags-modal/useGetAvailableCategories.tsx
Outdated
Show resolved
Hide resolved
g-saracca
previously approved these changes
Aug 7, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Hello! PR has branch conflicts- please resolve. Thanks! |
ofahimIQSS
moved this from Ready for QA ⏩
to Ready for Review ⏩
in IQSS Dataverse Project
Contributor
|
I will review again after merge conflicts are solved 👍🏼 |
…es-dropdown-with-results-from-api
g-saracca
approved these changes
Aug 15, 2025
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Looks good to me - merging |
ofahimIQSS
deleted the
772-file-edit-tags-populated-the-categories-dropdown-with-results-from-api
branch
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Get dataset categories for users, in Dataset Page and File Page, once they open the Edit Tags Modal
PACKAGE UPDATE NEEDED, WAITING IQSS/dataverse-client-javascript#344 THIS TO BE MERGED
Which issue(s) this PR closes:
Special notes for your reviewer:
Besides this function, also did some other changes
Suggestions on how to test this:
test the modal for both dataset page, and file page
check if the categories is automatically populated in Edit File -> Tags modal. Upload two files, type some custom file tags to file 1, check if file 2 has the File Tags dropdown options of these custom file tags.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: