Remove transform to markdown from Get Collection use case #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
SPA.Q1
ChengShi-1
reviewed
Feb 19, 2025
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Good! just one small thing
src/collections/infra/repositories/transformers/collectionTransformers.ts
Show resolved
Hide resolved
Contributor
|
merging is blocked for this - need a review |
Contributor
Author
|
@ChengShi-1 , I just added the fix for the new sorting from the API, can you review again? |
Contributor
|
merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To simplify the logic for managing HTML in strings, we are moving the conversion from HTML to markdown from the library to the frontend.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Review the code and tests
Is there a release notes update needed for this change?:
Additional documentation: