Collection Page: convert html to markdown in description field #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
SPA.Q1
g-saracca
requested changes
Feb 24, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
All good! Just 2 minor comments
Contributor
|
test/e2e is failing on this - please advise :) |
Contributor
Author
|
@ofahimIQSS I think this is a timing issue - the csv file has be ingested and converted to a tab-delimited file, which I think happens asynchronously on the server side. (I ran it locally and can't reproduce the error.)I updated the test to check the filterBy using text files, which don't have to be ingested. |
g-saracca
approved these changes
Feb 24, 2025
github-project-automation
bot
moved this from QA ✅
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
testing passed but need confirmation on why the UI review and tests are pending |
Contributor
|
@ofahimIQSS All UI Reviews passing. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Get Collection use case in js-dataverse was updated to return the html in the description field, rather than markdown. This PR converts the html returned from js-dataverse into markdown for the Collection Page. (In Edit Collection Page, it will show the original html).
Which issue(s) this PR closes:
Special notes for your reviewer:
This change depends on a js-dataverse PR IQSS/dataverse-client-javascript#265. When that PR is approved, package.json should be updated to use the alpha version of the library.
Suggestions on how to test this:
Step 1: Run the Development Environment
Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
Navigate with cd dev-env.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.
Step 2: Test the feature
Create a Collection and add html in the description field. The Collection Page should show the rendered html. Go to Edit Collection Page. It should show the original html that was submitted.