Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNS - CAN IO Trait #72

Merged
merged 30 commits into from
Feb 7, 2025
Merged

SNS - CAN IO Trait #72

merged 30 commits into from
Feb 7, 2025
+202 −49

Conversation

jpfbastos
Copy link
Contributor

@jpfbastos jpfbastos commented Feb 5, 2025 •
edited by davidbeechey
Loading

Can IO without derive so the trait can be used without the derive being fully finished.

Closes HYPE-110...

jpfbastos and others added 21 commits January 23, 2025 19:07
@jpfbastos
CAN IO code
64da3b6
@jpfbastos
rustfmt
bcc58af
@jpfbastos
added derive to the io file
694c62a
@jpfbastos
added envelope struct, comments and the try_ functions
d1831f5
@jpfbastos
clippy is still flagging some stuff, but they seem to be edge cases
eed5c85
@jpfbastos
see if it builds now
811fdba
@jpfbastos
matched embassy errors to CanError
c2a93fc
@jpfbastos
lol missed semicolon
14a49da
@jpfbastos
scrapped async because they're a pain
8d55d2b
@jpfbastos
removed blocking from Can
7fd9f24
@jpfbastos
Merge branch 'main' into hype-77-can-io-implementation
98f7ee8
@davidbeechey
Merge branch 'main' into hype-77-can-io-implementation
9ae813e
@davidbeechey
restore lockfiles
102146f
@davidbeechey
fix big long import chains
f4754dd
@jpfbastos
fixed comment in definition of write_frame, de-nested some of the mat…
6d520a6 
…ches when converting from embassy's frame to HypedCanFrame and vice versa
@jpfbastos
fixed bug
32279f1
@jpfbastos
ok my bad this should be it
bf3f270
@jpfbastos
:)
f53e20d
@jpfbastos
remove hyped-can-derive (surely it can't be this straightforward)
2d81bfa
@jpfbastos
removed from cargo.toml
6f48046
@jpfbastos
and from io
60467eb
@jpfbastos jpfbastos self-assigned this Feb 5, 2025
davidbeechey
davidbeechey requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, none of the changes to anything in boards/ needs to be there though so ideally remove

@davidbeechey davidbeechey changed the title Can IO simple SNS - CAN IO Trait Feb 5, 2025
@linear Linear
Copy link

linear bot commented Feb 5, 2025

HYPE-110 CAN IO trait

@jpfbastos
Copy link
Contributor Author

I've removed them, but now it flags as a removal - should I restore them to the original version, or is deleting them ok?

@davidbeechey
Copy link
Collaborator

I've removed them, but now it flags as a removal - should I restore them to the original version, or is deleting them ok?

restore to old version pls

@jpfbastos
Copy link
Contributor Author

jpfbastos commented Feb 6, 2025 •
edited
Loading

actually - should the main .lock file include the hyped-can package? i took it out, but it might be useful to have

TomLonergan03
TomLonergan03 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'first review from vim so maybe it'''s a little fucked up lol'

@TomLonergan03
Copy link
Contributor

'first review from vim so maybe it'''s a little fucked up lol'

definitely is lmao

@davidbeechey
Copy link
Collaborator

'first review from vim so maybe it'''s a little fucked up lol'

nerd :)

@davidbeechey davidbeechey merged commit 25bf8a5 into main Feb 7, 2025
15 checks passed
@davidbeechey davidbeechey deleted the can-io-simple branch February 7, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbeechey davidbeechey davidbeechey approved these changes

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes

@H-Allen H-Allen H-Allen approved these changes

Assignees

@jpfbastos jpfbastos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpfbastos @davidbeechey @TomLonergan03 @H-Allen