Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vc 1.4.3 #116772

Closed
wants to merge 2 commits into from
+11 −7
Closed

vc 1.4.3 #116772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79107c1
vc 1.4.3
chenrui333 Nov 27, 2022
8d3ae29
runtime_cpu_detection_allowlist: add vc
chenrui333 Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions Formula/vc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Vc < Formula
desc "SIMD Vector Classes for C++"
homepage "https://github.com/VcDevel/Vc"
url "https://github.com/VcDevel/Vc/releases/download/1.4.2/Vc-1.4.2.tar.gz"
sha256 "50d3f151e40b0718666935aa71d299d6370fafa67411f0a9e249fbce3e6e3952"
url "https://github.com/VcDevel/Vc/releases/download/1.4.3/Vc-1.4.3.tar.gz"
sha256 "988ea0053f3fbf17544ca776a2749c097b3139089408b0286fa4e9e8513e037f"
license "BSD-3-Clause"

bottle do
Expand All @@ -19,10 +19,13 @@ class Vc < Formula
depends_on "cmake" => :build

def install
mkdir "build" do
system "cmake", "..", "-DBUILD_TESTING=OFF", *std_cmake_args
system "make", "install"
end
# not filter out -march
# see discussion in here, https://github.com/VcDevel/Vc/issues/348#issuecomment-1328101410
ENV.runtime_cpu_detection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on audit, this is probably not right way and may end up optimizing binaries more than we want. If so, will need to use CMake arguments to override host CPU detection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any code suggestion?


system "cmake", "-S", ".", "-B", "build", "-DBUILD_TESTING=OFF", *std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"
end

test do
Expand Down
3 changes: 2 additions & 1 deletion style_exceptions/runtime_cpu_detection_allowlist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
"luajit",
"openblas",
"opencv",
"open-mpi"
"open-mpi",
"vc"
]