vc 1.4.3 #116772
Closed
vc 1.4.3 #116772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
chenrui333
added
the
CI-no-fail-fast
Signed-off-by: Rui Chen <[email protected]>
BrewTestBot
added
the
automerge-skip
Closed
cho-m
reviewed
Dec 11, 2022
| end | ||
| # not filter out -march | ||
| # see discussion in here, https://github.com/VcDevel/Vc/issues/348#issuecomment-1328101410 | ||
| ENV.runtime_cpu_detection |
There was a problem hiding this comment.
Based on audit, this is probably not right way and may end up optimizing binaries more than we want. If so, will need to use CMake arguments to override host CPU detection.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
chenrui333
added
the
help wanted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?continuing #102079
relates to VcDevel/Vc#348