Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper merged #31

Closed
wants to merge 80 commits into from
Closed

Paper merged #31

wants to merge 80 commits into from

Conversation

FireInstall
Copy link

@FireInstall FireInstall commented Feb 8, 2024

This is just a step back for me to look at my work as a whole picture.
However, since fixes and features lay the groundwork for importend changes, this branch will become the active one, later down the road.

todo

  • compile again
  • have a second look into breaking changes
  • heavy testing (MenuItemBlockData in special)
  • New unit tests (f Mockbukkit)
  • Entity Settings
  • clean langkey from possible duplicates
  • Check where MessageType success should be used instead of info since it was created later in development
  • Check todos
  • use bridg cmd api

@FireInstall FireInstall changed the title Paper merged2 [Draft] Paper merged2 Feb 8, 2024
@FireInstall FireInstall marked this pull request as draft February 8, 2024 14:32
@FireInstall FireInstall self-assigned this Feb 10, 2024
@FireInstall FireInstall added bug Something isn't working duplicate This issue or pull request already exists enhancement New feature or request labels Feb 10, 2024
@FireInstall FireInstall removed the duplicate This issue or pull request already exists label Feb 27, 2024
@FireInstall FireInstall force-pushed the paperMerged2 branch 2 times, most recently from 3483a60 to 4f599dc Compare February 27, 2024 18:22
@FireInstall FireInstall marked this pull request as ready for review February 27, 2024 18:23
@FireInstall
Copy link
Author

FireInstall commented Feb 27, 2024

There WILL be kinda big changes dependig on how deeply a Bug might be rooted.
However I'm done with functional changes.

... Not that there would be places where I still could or maby even should kepp changing things around, but I'm so done with this Project. Maybe one time in the future.

@FireInstall FireInstall changed the title [Draft] Paper merged2 Paper merged Apr 8, 2024
WIP - rework lang handling
Broke backwards compability with team messages (autobalancing etc.) - as long as you never configurated special messages for a team you should be fine.
If you did you may want to wait until a DataFixerUpper was written or may want to manually change them.
Dropped support for BukkitDisplayEntities. This does only support Paper or further downstream.
Start to adapt to Paper plugin system - still have to create paper-plugin.yml in resource to become effective outside of tests
sorted lang file

added team color material to TeamScoreRangeCondition
FireInstall and others added 12 commits June 11, 2024 15:25
Move to a more consistent load/save system for modules
Move to a more consistent registry system for RewardSchemes
…ith other registries and ban unchecked conversions and reflection.
Don't save default flags
Removed unused TakeCTFFlagEvent event call in CTFFlagSign since the actual handing is in CTFMechanic
Removed unused "shouldDisplayMessage" property from this event.
Made Mechanics contractors protected - MgMechanics should the only right way of getting an instance!
Fixing TeamColor to and from String handling
Throwing RuntimeExceptions when loading fails to stop overwriting data, that might be still savable by human
Removed some helper methods from TeamColor to be less confusing
load neutral / capture sign text from translation files
Fix wrongly saved trigger amount
 Renaming Tick trigger to be more intuitive
 Save node loactions as Locations
 Fix wrong scoreboard team names
@FireInstall
Copy link
Author

Hey @addstar right now I'm messing with the build system (--> switching to gradle to benefit from the paper plugins).
What's up with the .travis.yml? As far as I know Minigames gets build with jenkins. Is it just a forgotten artifact and can get safely removed or is it still used somewhere?

@FireInstall FireInstall marked this pull request as draft August 3, 2024 16:38
@FireInstall
Copy link
Author

Back to draft, as I'm fiddling with buildscript, tests and paper-plugins.

…'s worth it. Hopefully somebody will have the patience to implement tests in the future again.

- better .gitignore
- updated .readthedocs.yml
- set bug report template to paper or downstream
- updated workflow and added codacy to replace the old maven plugin
- removed old maven build scripts
- removed waffle.io badge as the site is no more
- better gradle build scripts (I really don't like build source)
- better version check
- move to paper plugin and added missing soft dependencies
- update kitteh.pastegg version
@FireInstall
Copy link
Author

dependency graph needs to get enabled for codacy.
paste.gg need to get a stable maven repo

# Conflicts:
#	Minigames/src/main/java/au/com/mineauz/minigames/Events.java
#	Minigames/src/main/java/au/com/mineauz/minigames/MinigameUtils.java
#	Minigames/src/main/java/au/com/mineauz/minigames/commands/JoinCommand.java
#	Minigames/src/main/java/au/com/mineauz/minigames/commands/SpectateCommand.java
#	Minigames/src/main/java/au/com/mineauz/minigames/managers/MinigamePlayerManager.java
#	Minigames/src/main/java/au/com/mineauz/minigames/managers/ResourcePackManager.java
#	Minigames/src/main/java/au/com/mineauz/minigames/objects/MinigamePlayer.java
#	Minigames/src/main/java/au/com/mineauz/minigames/objects/OfflineMinigamePlayer.java
#	Minigames/src/main/java/au/com/mineauz/minigames/signs/BetSign.java
#	Minigames/src/main/java/au/com/mineauz/minigames/signs/JoinSign.java
#	Minigames/src/main/java/au/com/mineauz/minigames/signs/SpectateSign.java
#	Minigames/src/test/java/au/com/mineauz/minigames/MinigamePlayerManagerTest.java
#	Minigames/src/test/java/au/com/mineauz/minigames/MinigamesTest.java
@FireInstall
Copy link
Author

Closed because the admin of our organisation receives too many notifications.
This branch will receive updates in the future regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant