Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make minigames more like a paper-plugin #25

Closed
wants to merge 29 commits into from
Closed

make minigames more like a paper-plugin #25

wants to merge 29 commits into from

Conversation

FireInstall
Copy link

@FireInstall FireInstall commented Jul 5, 2023

removed own position implementation, using the paper once should be fine

Broke backwards compability with team messages (autobalancing etc.) - as long as you never configurated special messages for a team you should be fine.
If you did you may want to wait until a DataFixerUpper was written or may want to manually change them.
Dropped support for BukkitDisplayEntities. This does only support Paper or further downstream.
Removed special permission messages. Just too much work for me. If anyone want's to bring them back feel free to do it.

@FireInstall
Copy link
Author

FireInstall commented Nov 10, 2023

This is done for what it does.
But there would be so much more one could do, to go fully paper.

@FireInstall
Copy link
Author

Big lang rework.
Builds will be broken for a while.

@FireInstall
Copy link
Author

Plugin voll durchpapern

WIP - rework lang handling
Broke backwards compability with team messages (autobalancing etc.) - as long as you never configurated special messages for a team you should be fine.
If you did you may want to wait until a DataFixerUpper was written or may want to manually change them.
Dropped support for BukkitDisplayEntities. This does only support Paper or further downstream.
@FireInstall
Copy link
Author

Can't bring myself to do anymore for this PR for a while. I need a break from all the translation keys.

For whoever works on this next: commands and menus are the big things to work on next. Most other things should already be done.

@FireInstall FireInstall self-assigned this Dec 20, 2023
Start to adapt to Paper plugin system - still have to create paper-plugin.yml in resource to become effective outside of tests
@FireInstall
Copy link
Author

Todo: Next to the bootstrapper also add the loader to ensure all dependencys are meet (At lastest, when adding the paper-plugin.yml)

sorted lang file

added team color material to TeamScoreRangeCondition
 removed getParameters() from command interface. It had its place in dokumentation, but was quite incomplete and broken for a long time.
 Reworked how Modules are created and accessed
@FireInstall FireInstall force-pushed the paper branch 2 times, most recently from 94c98bf to 5329df5 Compare January 13, 2024 16:22
"simplified" random chests command: removed true/false setting in favor of dis/enabling it via the two numeric parameters.
This way Users hopefully aren't as confused how to config this feature.

Added better time parsing for commands

Changed Reward system to match the Module one

removed label from commands it was never used

drop item rewards that doesn't fit into inventory
Found this Gem on my Shelf. Feel like I already committed it, but I cant find it.
Change throwables to Exceptions to not deal with Errors
Rename Notifier appropriately
Don't use normal logger anymore!
added second interface for set commands to make the difference to normal commands clearer
Move MinigameSpecific Broadcasts out of MinigameManager
merged stop command with end command to simplify code and don't make exemption just for global minigames. This means it is necessary now to have the permission to end minigames for others in order to stop global minigames!
@FireInstall FireInstall added the enhancement New feature or request label Feb 10, 2024
@FireInstall
Copy link
Author

Developing this Branch has finished.
Since compiling - and therefor finding errors and areas in Minigames Regions that hinder compiling yet - depends on changes from other branches further development will take place in #31
However, I still believe having this as a "clean" paper/lang branch might be useful for lookup, so I will keep this PR open for now!

@FireInstall
Copy link
Author

With the merge of the fixes branch and the rebase afterwards this became confusing. Closing it and deleting the branch.

@FireInstall FireInstall deleted the paper branch February 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant