feat(spanner): migrate batch 1 core samples and tests#4273
feat(spanner): migrate batch 1 core samples and tests#4273angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of Node.js samples for Google Cloud Spanner, covering CRUD operations, database and index management, encryption, and commit statistics, alongside a robust system test suite. The review feedback highlights several critical improvements: addressing a concurrency bug in the test cleanup logic, ensuring database closures are properly awaited for session pool management, and using string representations for INT64 values to prevent precision issues. Additionally, the feedback recommends avoiding unnecessary mutations of global library objects and removing redundant keywords to enhance code quality and maintainability.
|
Here is the summary of changes. You are about to add 16 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes Internal: b/497969229
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.