Skip to content

feat(spanner): migrate batch 1 core samples and tests#4273

Open
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:spanner-core-tests
Open

feat(spanner): migrate batch 1 core samples and tests#4273
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:spanner-core-tests

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Mar 31, 2026

Description

Fixes Internal: b/497969229

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Mar 31, 2026
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive suite of Node.js samples for Google Cloud Spanner, covering CRUD operations, database and index management, encryption, and commit statistics, alongside a robust system test suite. The review feedback highlights several critical improvements: addressing a concurrency bug in the test cleanup logic, ensuring database closures are properly awaited for session pool management, and using string representations for INT64 values to prevent precision issues. Additionally, the feedback recommends avoiding unnecessary mutations of global library objects and removing redundant keywords to enhance code quality and maintainability.

@angelcaamal angelcaamal marked this pull request as ready for review March 31, 2026 01:20
@angelcaamal angelcaamal requested review from a team as code owners March 31, 2026 01:20
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Mar 31, 2026

Here is the summary of changes.

You are about to add 16 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant