Skip to content

Workbench: Make install-nvidia-driver a settable metadata key #16650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScottSuarez merged 1 commit into from
Mar 10, 2026
Merged

Workbench: Make install-nvidia-driver a settable metadata key #16650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmv1/templates/terraform/constants/workbench_instance.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ var metadataDefaults = map[string]string{

var WorkbenchInstanceSettableUnmodifiableDefaultMetadata = []string{
"install-monitoring-agent",
"install-nvidia-driver",
Copy link
Contributor

@ScottSuarez ScottSuarez Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this be a breaking change for existing users?

Copy link
Contributor Author

@bcreddy-gcp bcreddy-gcp Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it be? Previously this key was ignored. Now, it is not-ignored on creation and it is ignored any other time. For already existing resources, since it is ignored, it should be safe. lmk if I am missing something.

Copy link
Contributor

@modular-apprentice modular-apprentice Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the particulars of implementation for this resource. I simply saw defaults changing which can be breaking in certain cases if they induce a diff on already created resources. Based on the exposition -- it is not, which makes sense and is allowed.

Copy link
Contributor

@ScottSuarez ScottSuarez Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ account swap

"serial-port-logging-enable",
"report-notebook-metrics",
}
Expand Down Expand Up @@ -51,7 +52,6 @@ var WorkbenchInstanceProvidedMetadata = []string{
"generate-diagnostics-options",
"google-logging-enabled",
"image-url",
"install-nvidia-driver",
"installed-extensions",
"instance-region",
"last_updated_diagnostics",
Expand Down