Workbench: Make install-nvidia-driver a settable metadata key

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: made `install-nvidia-driver` metadata key settable for `google_workbench_instance`

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 27
Passed tests: 25
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log

[ScottSuarez]

Won't this be a breaking change for existing users?

[bcreddy-gcp]

Why would it be? Previously this key was ignored. Now, it is not-ignored on creation and it is ignored any other time. For already existing resources, since it is ignored, it should be safe. lmk if I am missing something.

[modular-apprentice]

I don't know the particulars of implementation for this resource. I simply saw defaults changing which can be breaking in certain cases if they induce a diff on already created resources. Based on the exposition -- it is not, which makes sense and is allowed.

[ScottSuarez]

^^ account swap