Skip to content

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Feb 10, 2025

This PR contains the following updates:

Package Change Age Confidence
com.google.errorprone:error_prone_core (source) 2.31.0 -> 2.41.0 age confidence

Release Notes

google/error-prone (com.google.errorprone:error_prone_core)

v2.41.0: Error Prone 2.41.0

Compare Source

New checks:

  • EffectivelyPrivate: Detect declarations that have public or protected modifiers, but are effectively private

Changes:

  • Skip BooleanLiteral findings if the target type is boxed (#​5134)

Full changelog: google/error-prone@v2.40.0...v2.41.0

v2.40.0: Error Prone 2.40.0

Compare Source

Changes:

Full changelog: google/error-prone@v2.39.0...v2.40.0

v2.39.0: Error Prone 2.39.0

Compare Source

Changes:

  • Temporarily downgrade to Guava 33.4.0 (#​5108)

Checks:

  • BooleanLiteral: Prefer true to Boolean.TRUE
  • ExpensiveLenientFormatString: Renamed from PreconditionsExpensiveString, detects unnecessary calls to String.format in the arguments of lenient formatting methods.
  • UnnecessaryQualifier: Detects @Qualifier or @BindingAnnotation annotations that have no effect, and can be removed

Issues: #​4996, #​5045

Full changelog: google/error-prone@v2.38.0...v2.39.0

v2.38.0: Error Prone 2.38.0

Compare Source

New checks:

Closed issues: #​4924, #​4897, #​4995

Full changelog: google/error-prone@v2.37.0...v2.38.0

v2.37.0: Error Prone 2.37.0

Compare Source

Changes:

  • The annotations that were previously in error_prone_type_annotations have been been merged into error_prone_annotations. error_prone_type_annotations is now deprecated, and will be removed in a future release.

New checks:

  • AssignmentExpression - The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.
  • IntFloatConversion - Detect calls to scalb that should be using the double overload instead
  • InvalidSnippet - Detects snippets which omit the : required for inline code.
  • JUnit4EmptyMethods - Detects empty JUnit4 @Before, @After, @BeforeClass, and @AfterClass methods.
  • MockIllegalThrows - Detects cases where Mockito is configured to throw checked exception types which are impossible.
  • NegativeBoolean - Prefer positive boolean names.
  • RuleNotRun - Detects TestRules not annotated with @Rule, that won't be run.
  • StringConcatToTextBlock - Replaces concatenated multiline strings with text blocks.
  • TimeInStaticInitializer - Detects accesses of the system time in static contexts.

Closed issues:

  • Propagate check flags in patch mode (#​4699)
  • Fixes a crash in ComputeIfAbsentAmbiguousReference (#​4736)
  • Show the field name in HidingField diagnostics (#​4775)
  • Add support for jakarta annotations to some checks (#​4782)
  • FloatingPointAssertionWithinEpsilonTest depends on default locale (#​4815)
  • @InlineMe patching of Strings.repeat produces broken code (#​4819)
  • Fix a crash in IdentifierName on unnamed (_) variables (#​4847)
  • Fix a crash in ArgumentParameterSwap (#​490)

Full changelog: google/error-prone@v2.36.0...v2.37.0

v2.36.0: Error Prone 2.36.0

Compare Source

Changes:

  • Add new matcher interfaces to ErrorProneScanner for AST nodes introduced after Java 11 (e5fd194)
  • Fix compatibility with latest JDK 24 EA builds (d67bc15)
  • Check that --should-stop=ifError=FLOW is set when using the -Xplugin integration (e71db1f)

New checks:

Closed issues: #​4633, #​4646

Full changelog: google/error-prone@v2.35.1...v2.36.0

v2.35.1: Error Prone 2.35.1

Compare Source

Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release.

Version 3.25.5 of protobuf still fixes CVE-2024-7254. This release is provided for users who aren't ready to update to 4.x, see also #​4584 and #​4634. Future versions of Error Prone will upgrade back to protobuf 4.x.

Full changelog: google/error-prone@v2.35.0...v2.35.1

v2.35.0: Error Prone 2.35.0

Compare Source

Changes:

  • Fix handling of \s before the trailing delimiter in MisleadingEscapedSpace
  • TimeUnitMismatch improvements: handle binary trees, consider trees like fooSeconds * 1000 to have units of millis

New checks:

Full changelog: google/error-prone@v2.34.0...v2.35.0

v2.34.0: Error Prone 2.34.0

Compare Source

Changes:

  • Passing the javac flag --should-stop=ifError=FLOW is now required when running Error Prone (#​4595)
  • The MemberName check was renamed to IdentifierName

New checks:

Closed issues: #​4595, #​4598, #​4620

Full changelog: google/error-prone@v2.33.0...v2.34.0

v2.33.0: Error Prone 2.33.0

Compare Source

Similar to release 2.32.0, the minimum supported JDK version to run Error Prone is JDK 17 (#​3803). Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will require using JDK 17 or newer for compilation and setting --release or -source/-target/-bootclasspath.

Changes:

New checks:

Full changelog: google/error-prone@v2.32.0...v2.33.0

v2.32.0: Error Prone 2.32.0

Compare Source

The minimum support JDK version to run Error Prone is now JDK 17 (#​3803).

Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will requires using JDK 17 or newer for compilation and setting --release or -source/-target/-bootclasspath.

Full changelog: google/error-prone@v2.31.0...v2.32.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@enocom
Copy link
Member

enocom commented Feb 10, 2025

Relevant: https://github.com/google/error-prone/releases/tag/v2.31.0

v2.31.0 was the last version that supports JDK 11. There might be a way to work around this, but it's low priority.

We need to support Java 8 until Sept 2026. See https://cloud.google.com/java/docs/supported-java-versions.

@enocom enocom assigned enocom and unassigned rhatgadkar-goog Feb 10, 2025
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch from 18cdeba to e3b7a9f Compare March 19, 2025 18:31
@renovate-bot renovate-bot changed the title deps: Update dependency com.google.errorprone:error_prone_core to v2.36.0 deps: Update dependency com.google.errorprone:error_prone_core to v2.37.0 Mar 19, 2025
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch from e3b7a9f to 532b725 Compare April 15, 2025 20:33
@renovate-bot renovate-bot changed the title deps: Update dependency com.google.errorprone:error_prone_core to v2.37.0 deps: Update dependency com.google.errorprone:error_prone_core to v2.38.0 Apr 18, 2025
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch from 532b725 to 874f652 Compare April 18, 2025 17:28
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch from 874f652 to 21d89fa Compare May 19, 2025 19:21
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch 19 times, most recently from d88e47c to fb03f12 Compare May 28, 2025 21:03
@enocom
Copy link
Member

enocom commented Aug 8, 2025

@enocom enocom removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 11, 2025
@enocom enocom force-pushed the renovate/error-prone-core branch 4 times, most recently from eb73153 to 6c8dfb0 Compare September 12, 2025 03:55
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch 2 times, most recently from 40ea12b to f206b9c Compare September 12, 2025 22:01
@enocom enocom force-pushed the renovate/error-prone-core branch 3 times, most recently from 581bcf3 to 02272e3 Compare September 13, 2025 02:36
@renovate-bot renovate-bot force-pushed the renovate/error-prone-core branch from 02272e3 to 26d1963 Compare September 13, 2025 02:39
@enocom enocom force-pushed the renovate/error-prone-core branch 8 times, most recently from 3f5bd2b to c1fed16 Compare September 13, 2025 04:53
…41.0

- Move errorprone to Java 17 and higher builds
- Use new argument for stopping build on warning
- Fix various problems identified by new errorprone version
@enocom enocom force-pushed the renovate/error-prone-core branch from c1fed16 to 2357ebe Compare September 13, 2025 04:57
@enocom enocom enabled auto-merge (squash) September 13, 2025 05:04
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@enocom enocom assigned nancynh and unassigned enocom Sep 15, 2025
<id>java17</id>
<activation>
<jdk>[9,)</jdk>
<jdk>[17,)</jdk>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go ahead and make the ErrorProne run only on 21 like we talked about maybe doing earlier?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll send a follow-up CL to clean this up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #675 to do this and will experiment as time allows with various ways of cleaning up our pom file to surface ErrorProne warnings in a nice way.

@enocom enocom merged commit 8ea3ade into GoogleCloudPlatform:main Sep 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants