deps: Update dependency com.google.errorprone:error_prone_core to v2.41.0 (#612)

- Move errorprone to Java 17 and higher builds
- Use new argument for stopping build on warning
- Fix various problems identified by new errorprone version

Co-authored-by: Eno Compton <[email protected]>

Author: renovate-bot

alloydb-jdbc-connector/src/main/java/com/google/cloud/alloydb/ConnectionConfig.java

@@ -115,9 +115,8 @@ private static void validateProperties(Properties props) {
     final String instanceNameStr = props.getProperty(ALLOYDB_INSTANCE_NAME, "");
     Preconditions.checkArgument(
         InstanceName.isParsableFrom(instanceNameStr),
-        String.format(
-            "'%s' must have format: projects/<PROJECT>/locations/<REGION>/clusters/<CLUSTER>/instances/<INSTANCE>",
-            ALLOYDB_INSTANCE_NAME));
+        "'%s' must have format: projects/<PROJECT>/locations/<REGION>/clusters/<CLUSTER>/instances/<INSTANCE>",
+        ALLOYDB_INSTANCE_NAME);
   }
 
   private ConnectionConfig(

alloydb-jdbc-connector/src/main/java/com/google/cloud/alloydb/RefreshCalculator.java

@@ -29,6 +29,7 @@ class RefreshCalculator {
   // time to complete.
   static final Duration DEFAULT_REFRESH_BUFFER = Duration.ofMinutes(4);
 
+  @SuppressWarnings("JavaDurationGetSecondsToToSeconds")
   long calculateSecondsUntilNextRefresh(Instant now, Instant expiration) {
     Duration timeUntilExp = Duration.between(now, expiration);
 

alloydb-jdbc-connector/src/test/java/com/google/cloud/alloydb/LazyConnectionInfoCacheTest.java

@@ -29,6 +29,7 @@
 import org.bouncycastle.operator.OperatorCreationException;
 import org.junit.Test;
 
+@SuppressWarnings("TimeInStaticInitializer")
 public class LazyConnectionInfoCacheTest {
 
   private static final Instant ONE_HOUR_AGO =

alloydb-jdbc-connector/src/test/java/com/google/cloud/alloydb/RefreshAheadConnectionInfoCacheTest.java

@@ -37,6 +37,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
+@SuppressWarnings("TimeInStaticInitializer")
 public class RefreshAheadConnectionInfoCacheTest {
 
   private static final String TEST_INSTANCE_IP = "10.0.0.1";

alloydb-jdbc-connector/src/test/java/com/google/cloud/alloydb/RefreshCalculatorTest.java

@@ -28,6 +28,7 @@
 import org.junit.runners.Parameterized.Parameters;
 
 @RunWith(Parameterized.class)
+@SuppressWarnings("TimeInStaticInitializer")
 public class RefreshCalculatorTest {
 
   private final Duration input;

pom.xml

@@ -59,7 +59,7 @@
     <github.global.server>github</github.global.server>
     <site.installationModule>alloydb-connector-parent</site.installationModule>
     <project.javadoc.protobufBaseURL>https://googleapis.dev/java/google-api-grpc/latest</project.javadoc.protobufBaseURL>
-    <error-prone.version>2.31.0</error-prone.version>
+    <error-prone.version>2.41.0</error-prone.version>
     <error-prone-annotations.version>2.41.0</error-prone-annotations.version>
     <bouncycastle.version>1.81</bouncycastle.version>
   </properties>
@@ -179,9 +179,9 @@
 
   <profiles>
     <profile>
-      <id>java9</id>
+      <id>java17</id>
       <activation>
-        <jdk>[9,)</jdk>
+        <jdk>[17,)</jdk>
       </activation>
       <build>
         <plugins>
@@ -194,6 +194,7 @@
               <fork>true</fork>
               <compilerArgs>
                 <arg>-XDcompilePolicy=simple</arg>
+                <arg>--should-stop=ifError=FLOW</arg>
                 <arg>-Xplugin:ErrorProne</arg>
                 <arg>-Xlint:-options</arg>
                 <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg>