Fix geometry overlap triggers #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKajan
force-pushed
the
fix-overlap-triggers
branch
from
f2a7236 to
8379efe
Compare
Merged
The logic of the trigger didn't work when regulation groups and plan objects have n2n relation. Plan objects are inserted first before knowing its regulation groups. Probably equivalent check should be added to just land_use_area.
LKajan
force-pushed
the
fix-overlap-triggers
branch
from
8379efe to
01fbdf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poistaa päällekkäisyystarkistuksen other_area taulusta ja lisää vastaavan land_use_area tauluun.
Aiemmin other_area -taulussa oli koitettu tehdä triggeriä, joka varmistaisi, että kaksi pääkäyttötarkoituksellista kohdetta ei leikkaisi toistensa kanssa. Pääkäyttötarkoitukselliset kohteet on kuitenkin tarkoitus tallentaa land_use_area tauluun, jossa on vain kaikki pääkäyttötarkoiutkselliset kohteet, jolloin kaavamääräysten lisätietoja ei tarvitse tarkistaa.
Riippuvainen #401:stä. Vaikka kaavakohteelle on testissä asettanut kaavan, niin triggeri asettaa kaavan NULLiksi. Testi ei mene läpi ennen #401:n mergeä.