N2n regulation groups #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKajan
force-pushed
the
n2n-regulation-groups
branch
from
1aa29ef to
0d8e05b
Compare
Rikuoja
previously requested changes
Nov 28, 2024
LKajan
force-pushed
the
n2n-regulation-groups
branch
2 times, most recently
from
af47709 to
85797c9
Compare
SqlAlchemy is not so happy of our choise to use same association table for multiple tables. Therefore we must tell that multiple relations overlaps and use the same regulation_group_id field.
Don't try to find lifecycle status from plan objects. In a creation time regulation group might not belong to any plan object or it might belong to many plan objects. There is no simply rule how to define from which plan object the lifecylcle status is read from. There is still a BI trigger that sets the lifecycle status from the plan.
Plan regulation groups and therefore regulations can belong to multiple plan objects. This means that the lifecycle status of a regulation can't be updated automatically when a plan object is updated. Lifecycle status of regulations are still updated when a lifecycle status of a plan is updated.
LKajan
force-pushed
the
n2n-regulation-groups
branch
from
85797c9 to
41a1d70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements n2n relations between plan objects and regulation groups.
This PR is based on #385
Depends on:
All these three should be merged before this one