data(brand): backfill founded_year and website for known brands - #46
Merged
Merged
Conversation
Add factual founded_year (25 brands) and official website (6 brands) where confidently known; uncertain/defunct brands left untouched to avoid wrong dates or dead links. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backfill brand metadata for brands with confidently-known facts:
founded_yearfor 25 brands (Casio 1957, HP 1939, Dell 1984, Amazon 1994, Bosch 1886, Mitsubishi 1921, Sagem 1925, Vodafone 1991, Sony Ericsson 2001, BenQ-Siemens 2005, Fujitsu Siemens 1999, Palm 1992, Thuraya 1997, Haier 1984, O2 2002, Benefon 1988, Sendo 1999, Neonode 2004, MiTAC 1982, Amoi 1997, Ningbo Bird 1992, Sonim 1999, Modu 2007, INQ 2008, Blackview 2013).websitefor 6 active brands (Thuraya, Haier, Bosch, Orange, Prestigio, Vodafone).Uncertain founding years and ambiguous/defunct websites were intentionally left blank (no wrong dates, no dead links). Matching
site/public/v1/brandsdump details refreshed.Verification
python -m app.validatePASSpython TechEngine/integrity_check.py data --strictPASSgit diff --check origin/main...HEADPASSCloses #1