data(brand): enrich logo/website/founded_year from Wikidata - #47
Merged
Merged
Conversation
Seungpyo1007
force-pushed
the
data/brand-wikidata
branch
from
June 21, 2026 20:17
0a10683 to
9a67ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enrich brand metadata from authoritative Wikidata (P154 logo, P856 website, P571 inception):
logo_urlfor 17 brandswebsitefor 26 brandsfounded_yearfor 21 brandsAll values come from Wikidata entities filtered by a description guard (must read as a company/electronics/phone/tech entity), which correctly skips wrong-name collisions (Amoi→Indonesian village, Bird→surname, etc.). Gap-only: existing values (incl. the hand-verified founded_years from #46) are never overwritten. Matching
site/public/v1/brandsdump details refreshed.Verification
python -m app.validatePASSpython TechEngine/integrity_check.py data --strictPASSgit diff --check origin/main...HEADPASScommons.wikimedia.org/wiki/Special:FilePath/<file>redirect. Local site build skipped (worktree without node_modules; build-safe metadata; TechEngine homepage validation builds).Closes #1