fix(data): correct storage, battery and display fields from each record's own text - #301
Merged
Merged
Conversation
…itor size/resolution from each record's own text - tablet/watch storage_options_gb re-parsed from memory_internal where the import mixed the RAM size into the storage list (259 records) - iPad Pro 12.9 (2015, 2017) battery_mah restored from the raw battery text - 3 laptops: storage_gb taken from the configuration in the model name - monitors: size_inch and resolution taken from the listing name (5), and aspect_ratio nulled where it contradicts the pixel resolution (24) Refs #296
github-actions
Bot
added
bug
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Self-consistency fixes: every corrected value is derived from text already in the same record, with no outside lookups. Closes #296.
storage_options_gbheld the RAM size mixed into the storage list (e.g.[1, 16]for "8/16 GB, 1 GB RAM"). Re-parsed frommemory_internal. Records whose raw text lists several editions ("16 GB, 2 GB RAM - Standard edition 32 GB, 3 GB RAM - Premium") were left untouched, because a single-list parse would drop an edition.battery_mahhad lost the thousands digit (307 / 891); restored to 10,307 / 10,891 from the raw battery text.storage_gbnow matches the configuration in the model name (e.g.i7-7500U/8GB/128GB).size_inch(3) andresolution(2) now match the listing name.aspect_ratiois nulled where it contradicts the pixel resolution (24, e.g.78:1for 1920x1080).Not changed: 43 devices whose release date is more than 2 years before their chip, and 15 records whose slug RAM disagrees with
ram_gb. The correct value isn't derivable from the record, so they need sourcing.Source
Each record's own
memory_internal, raw battery text and product name.Checklist
developpython -m app.validatepasses locally