Skip to content

fix(data): self-consistency correction for 1 PDA record - #340

Merged
Seungpyo1007 merged 1 commit into
developfrom
Seungpyo1007/pda-derivation
Sep 29, 2026
Merged

Seungpyo1007 merged 1 commit into
developfrom
Seungpyo1007/pda-derivation

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Within-record self-consistency pass over data/pda/ (140 records), following the established pattern from #301 (derive only from a record's own fields; never invent or fetch external sources).

Found and fixed one unambiguous within-record inconsistency:

  • data/pda/palm/2018/palm/palm.json had storage_options_gb: [3, 32]. The 3 is the RAM value (
    am_gb: 3, �ariant.memory.ram_gb: 3) that leaked into the storage list. The record's own �ariant.memory.storage_gb: 32 confirms storage is 32 GB only. Removed the stray 3 -> [32].

Reviewed but intentionally left (ambiguous, per task rules)

  • Rounding artifacts (6 records: i-mate PDAL, Mitac A701 x2/A501/A502/A702):
    aw_source.memory_internal says '64 MB RAM' (= 0.0625 GB) while
    am_gb is stored as

Closes #296

The 2018 Palm record listed storage_options_gb as [3, 32], but the 3 is the RAM value (ram_gb=3, variant.memory.ram_gb=3) leaked into the storage list. The record's own variant.memory.storage_gb=32 confirms storage is 32 GB only. Removed the stray 3 -> [32], derived solely from the record's own fields.

Refs #296
@github-actions github-actions Bot added bug Something isn't working data Dataset changes enhancement New feature or request labels Sep 29, 2026
@Seungpyo1007
Seungpyo1007 merged commit e174584 into develop Sep 29, 2026
5 checks passed
@Seungpyo1007
Seungpyo1007 deleted the Seungpyo1007/pda-derivation branch September 29, 2026 15:06
@Seungpyo1007 Seungpyo1007 removed the enhancement New feature or request label Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data Dataset changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Data accuracy: corrections, duplicates and dates (workstream)

1 participant