FIX: Use correct priority increment amounts #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an overridable method to FCGuiAmount to allow subclasses to specify increment values other than the default. AE2 has config values to set how much each button in the priority screen should increment a fluid storage bus's (or other's) priorty by. Prior to this change, the priority interface on fluid storage bus' were using the increment values for crafting, instead of those for priority.
michaeldoylecs
changed the title
|
is this really necessary to add this encapsulation? |
|
Increase code complexity for no reason. |
It is not. I would actually prefer having a separate class for priority gui. I went with this approach since it was a significantly smaller commit and can be both reviewed, added, or removed quite quickly if ever wanted to. If the alternative approach, which would match base AE2 implementation, is suggested, I can update with that. |
Caedis
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When setting the priority on an ME Fluid Storage Bus, the displayed button values are using the
craftAmtButton#config values instead of thepriorityAmtButton#config values. This is inconsistent with the non-fluid ME Storage Bus behavior.The interface in question:
Solution
Add an overridable method,
getIncrementQuantity, toFCGuiAmountso that the subclassGuiFCPrioritycan specify to use priority values instead of the default crafting values.