Remove unrequired Windows clang build in GitHub #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Without merging this pr here, the CI is labelled as "broken" because clang build fails.) |
adam-sawicki-a
merged commit 811773f
into
GPUOpen-LibrariesAndSDKs:master
2 checks passed
|
OK, thanks. If we just test Clang on Linux, this is fine. I guess errors and warnings from this compiler should be similar on any platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more thing about #469:
I removed windows clang build in CI because it's not working for now.
Maybe I can find a way to use clang for Windows using some offical repositories.