-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow for continuous integration for Windows #469
Add GitHub workflow for continuous integration for Windows #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise looks good to me.
I noticed that a downloadable artifact is a ZIP archive with another ZIP archive inside. Can we avoid this double-packing? I am not sure if we need any artifacts to download later. This is a library distributed in the source form. All we need from the automated builds is the log with errors and warnings. |
I can see you are downloading LLVM from repository https://github.com/zufuliu/llvm-utils. It doesn't look like an official LLVM account. Is there no official distribution of those binaries? |
Oh, true. I will remove this and see if it still compiles (if clang is installed by default in visual studio in the workflow). |
It seems that Clang has failed.
|
|
Related to #467
We can already use GitHub actions for continuous integration (CI) for the Windows build.
This workflow builds the code using MSVC compiler and clang for Windows, each in both debug and release configuration.
The results are uploaded as artifacts in a nightly build.
Let me know if you request changes to the workflow.
best regards
Johannes