Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow for continuous integration for Windows #469

Merged
merged 4 commits into from
Mar 28, 2025

Conversation

IAmNotHanni
Copy link
Contributor

Related to #467

We can already use GitHub actions for continuous integration (CI) for the Windows build.
This workflow builds the code using MSVC compiler and clang for Windows, each in both debug and release configuration.
The results are uploaded as artifacts in a nightly build.

Let me know if you request changes to the workflow.

best regards
Johannes

Copy link
Contributor

@adam-sawicki-a adam-sawicki-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise looks good to me.

@adam-sawicki-a
Copy link
Contributor

adam-sawicki-a commented Mar 26, 2025

I noticed that a downloadable artifact is a ZIP archive with another ZIP archive inside. Can we avoid this double-packing?

I am not sure if we need any artifacts to download later. This is a library distributed in the source form. All we need from the automated builds is the log with errors and warnings.

@adam-sawicki-a
Copy link
Contributor

I can see you are downloading LLVM from repository https://github.com/zufuliu/llvm-utils. It doesn't look like an official LLVM account. Is there no official distribution of those binaries?

@IAmNotHanni
Copy link
Contributor Author

I noticed that a downloadable artifact is a ZIP archive with another ZIP archive inside. Can we avoid this double-packing?

I am not sure if we need any artifacts to download later. This is a library distributed in the source form. All we need from the automated builds is the log with errors and warnings.

Oh, true. I will remove this and see if it still compiles (if clang is installed by default in visual studio in the workflow).
If not, I will just remove clang for Windows for now. It's not that important I think, and we still have clang for Linux.

@adam-sawicki-a adam-sawicki-a merged commit 9d7a52b into GPUOpen-LibrariesAndSDKs:master Mar 28, 2025
@adam-sawicki-a
Copy link
Contributor

It seems that Clang has failed.

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(459,5): error MSB8020: The build tools for LLVM_v143 (Platform Toolset = 'LLVM_v143') cannot be found. To build using the LLVM_v143 build tools, please install LLVM_v143 build tools. Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [D:\a\VulkanMemoryAllocator\VulkanMemoryAllocator\build\CMakeFiles\3.31.6\VCTargetsPath.vcxproj]

@IAmNotHanni
Copy link
Contributor Author

IAmNotHanni commented Mar 28, 2025

It seems that Clang has failed.

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(459,5): error MSB8020: The build tools for LLVM_v143 (Platform Toolset = 'LLVM_v143') cannot be found. To build using the LLVM_v143 build tools, please install LLVM_v143 build tools. Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [D:\a\VulkanMemoryAllocator\VulkanMemoryAllocator\build\CMakeFiles\3.31.6\VCTargetsPath.vcxproj]

#473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants