Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries using versions now use a serialization that requires 4.1 #3245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −18
Open

Queries using versions now use a serialization that requires 4.1 #3245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe26701
update gradle.properties to 4.2
alecgrieser Mar 11, 2025
e5b1904
Queries using versions now use a serialization that requires 4.1
alecgrieser Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions .../src/main/java/com/apple/foundationdb/record/query/plan/cascades/values/VersionValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,23 +149,9 @@ public boolean equals(final Object other) {
@Nonnull
@Override
public PVersionValue toProto(@Nonnull final PlanSerializationContext serializationContext) {
if (childValue instanceof QuantifiedRecordValue) {
// Deprecated. This value previously required that the child be a QuantifiedRecordValue and only
// contained the alias. To preserve cross-version compatibility with versions older than 4.0.561.0,
// send messages without the full value.
// Note: it's tempting to also include the full value in the `child` field, but doing so can
// lead to mixed-mode errors. If there are types or plans referenced in the child, those can
// be registered with the serializationContext, which means they may only be included
// by reference elsewhere in the serialized plan. Older versions of the deserialization
// logic don't know about the field, and so they will trip over any dangling references
return PVersionValue.newBuilder()
.setBaseAlias(getChildQuantifiedRecordValue().getAlias().getId())
.build();
} else {
return PVersionValue.newBuilder()
.setChild(childValue.toValueProto(serializationContext))
.build();
}
return PVersionValue.newBuilder()
.setChild(childValue.toValueProto(serializationContext))
.build();
}

@Nonnull
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#

rootProject.name=fdb-record-layer
version=4.1.9.0
version=4.2.0.0
releaseBuild=false

# this should be false for release branches (i.e. if there is no -SNAPSHOT on the above version)
Expand Down
Loading