Queries using versions now use a serialization that requires 4.1 #3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FoundationDB#2943, a new serialization of the `VersionValue` was introduced, though we had to modify it in FoundationDB#3179 so to avoid deserialization problems when serializing and deserializing continuations across 4.0 and 4.1. With 4.2, we want to start using the new serialization path to serialize `VersionValue` children more completely. This also bumps the minor version to 4.2. This resolves FoundationDB#3203.
alecgrieser
requested review from
pengpeng-lu,
normen662 and
hatyo
and removed request for
normen662 and
pengpeng-lu
normen662
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2943, a new serialization of the
VersionValuewas introduced, though we had to modify it in #3179 so to avoid deserialization problems when serializing and deserializing continuations across 4.0 and 4.1. With 4.2, we want to start using the new serialization path to serializeVersionValuechildren more completely.The mixed mode testing in PRB validate this change is compatible with 4.1.9.0. I've also run the full mixed mode battery for the
versionsTesttests, and the serialization is compatible between this change and all 4.1 versions, as well as all 4.0 versions after 4.0.562.0, which is in line with what we'd expect.This resolves #3203.