Add JsonMapper.builderWithJackson2Defaults()
#5004
Merged
+74
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
reviewed
Mar 6, 2025
cowtowncoder
reviewed
Mar 6, 2025
cowtowncoder
reviewed
Mar 6, 2025
cowtowncoder
reviewed
Mar 6, 2025
| { | ||
| ObjectMapper mapper = JsonMapper.builderWithJackson2Defaults().build(); | ||
| JsonFactory jsonFactory = (JsonFactory) mapper.tokenStreamFactory(); | ||
| assertFalse(mapper.isEnabled(StreamReadFeature.USE_FAST_DOUBLE_PARSER)); |
There was a problem hiding this comment.
Should also not verify streaming-level setting at databind level.
There was a problem hiding this comment.
People who want max Jackson2 compatibility will want mapper and factory level Jackson2-like config.
There was a problem hiding this comment.
Yes, but it must be done at correct level -- streaming at streaming, databind at databind. Not with overlap.
There was a problem hiding this comment.
JsonMapper.builderWithJackson2Defaults() is a high level method that creates a factory for you.
I have modified the lower level configureForJackson2 methods not to set factory level configs.
cowtowncoder
approved these changes
Mar 6, 2025
cowtowncoder
changed the title
cowtowncoder
changed the title
JsonMapper.builderWithJackson2Defaults()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonFactoryBuilder.configureForJackson2(),JsonFactoryBuilder builderWithJackson2Defaults()jackson-core#1411 or equivalent first