Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configureForJackson2() with XmlMapper #731

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Mar 6, 2025

@cowtowncoder will you notify me when the config changes are finished so that I can update this PR

@pjfanning pjfanning marked this pull request as draft March 6, 2025 09:16
@cowtowncoder cowtowncoder changed the title support configureForJackson2 Support configureForJackson2() with XmlMapper Mar 6, 2025
@pjfanning pjfanning marked this pull request as ready for review March 6, 2025 23:44
@cowtowncoder
Copy link
Member

@pjfanning Yes; realized I hadn't checked XmlReadFeature: changing now as #732, will add a note once merged.

@cowtowncoder
Copy link
Member

Ok, #732 now merged to master.

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: need just that one change wrt #732.

@pjfanning
Copy link
Member Author

LGTM: need just that one change wrt #732.

That should be supported now

@cowtowncoder cowtowncoder merged commit 8a04feb into FasterXML:master Mar 7, 2025
3 checks passed
cowtowncoder added a commit that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants