[DONE] Pampletousse/feature download qrcode #1015

pampletousse · 2023-12-18T09:27:12Z

Add download button for QR Code (to replace usage of right-click -> save as) + Fix border red on all share video pannel -> only on if is draft

ptitloup

Merci

ptitloup · 2023-12-18T15:32:00Z

pod/main/static/js/main.js

@@ -300,6 +300,37 @@ document.addEventListener("hidden.bs.collapse", (e) => {
  if (e.target.id === "qrcode") e.target.setAttribute("src", "");
 });

+document.getElementById("btnDowloadQrCode").addEventListener('click', (e) => {


je pense qu'il faut d'abord tester si l'element est présent avant de lui asigner un event listener non ?
Ne pourait-on pas mettre ce code dans un fichier de l'app video plutot ? c'est utilisé que sur une page de visualisation de la vidéo.
Merci

D'accord sur ce point !

J'étais d'accord jusqu'à ce que je m'aperçoive que le QR code est aussi disponible pour les évènements live ^^ Je vais donc le laisser dans main et faire aussi la modif côté live. Je peux aussi l'externaliser dans un fichier js spécifique mais peu d'interêt vu le nombres de lignes...

ptitloup · 2023-12-18T15:32:36Z

pod/video/templates/videos/video-info.html

@@ -311,7 +311,7 @@ <h2 class="modal-title h3" id="shareLabel">
      </div>
      <div class="modal-body">

-        <div {% if video.is_draft %}style="border:1px solid red" {% endif %}>
+        <div>


ok pour moi

ptitloup · 2023-12-18T15:33:19Z

pod/video/templates/videos/video-info.html

@@ -342,7 +342,7 @@ <h2 class="modal-title h3" id="shareLabel">
            <hr>
          {% endif %}
          {% if video.is_draft %}
-          <div class="card text-white bg-danger mb-3">
+          <div class="card text-white border-danger mb-3">


oui ok pour ne mettre que la bordure en rouge plutot que le fond mais il me semble que les remarques de l'époque disait que ce n'etait pas assez visible... peut etre que les temps ont changé.

SebastienCozeDev

Je n'ai regardé que le code pour le moment

SebastienCozeDev · 2024-01-04T09:05:33Z

pod/video/templates/videos/video-info.html

-                <img src="" data-src="//chart.apis.google.com/chart?cht=qr&amp;chs=200x200&amp;chl={% if request.is_secure %}https{% else %}http{% endif %}://{{ request.META.HTTP_HOST }}{% if enrichment%}{% url 'enrichment:video_enrichment' slug=video.slug %}{% else %}{% url 'video:video' slug=video.slug %}{% endif %}{% if video.is_draft == True %}{{ video.get_hashkey }}/{% endif %}" alt="{% trans 'QR code' %}" id="qrcode" loading="lazy" class="collapse">
+              <div class="form-group m-2">
+                <label>{% trans 'QR code for this link:' %}&nbsp;</label>
+                  <a href="#" class="btn btn-primary m-2" title="{% trans 'Warning, it use google API' %}" role="button" data-bs-toggle="collapse" data-bs-target="#qrcode" aria-expanded="false" aria-controls="qrcode">{% trans 'Voir le QR Code' %}</a>


Je pense qu'il est préférable de mettre le Voir le QR Code en anglais

AymericJak

Merci pour les changements, juste une petite révision et c'est bon pour moi :)

AymericJak · 2024-01-04T08:52:24Z

pod/main/static/js/main.js

@@ -300,6 +300,37 @@ document.addEventListener("hidden.bs.collapse", (e) => {
  if (e.target.id === "qrcode") e.target.setAttribute("src", "");
 });

+document.getElementById("btnDowloadQrCode").addEventListener('click', (e) => {


D'accord sur ce point !

AymericJak · 2024-01-04T09:15:08Z

pod/video/templates/videos/video-info.html

+                  <a href="#" class="btn btn-primary m-2" title="{% trans 'Warning, it use google API' %}" role="button" data-bs-toggle="collapse" data-bs-target="#qrcode" aria-expanded="false" aria-controls="qrcode">{% trans 'Voir le QR Code' %}</a>
+                  <button id="btnDowloadQrCode" type="submit" data-slug={{ video.slug }} class="btn btn-primary" title="{% trans 'Warning, it use google API' %}">{% trans 'Download' %}</button>
+                  <img src="" data-src="//chart.apis.google.com/chart?cht=qr&amp;chs=200x200&amp;chl={% if request.is_secure %}https{% else %}http{% endif %}://{{ request.META.HTTP_HOST }}{% if enrichment%}{% url 'enrichment:video_enrichment' slug=video.slug %}{% else %}{% url 'video:video' slug=video.slug %}{% endif %}{% if video.is_draft == True %}{{ video.get_hashkey }}/{% endif %}"
+                     alt="{% trans 'QR code' %}" id="qrcode" loading="lazy" class="collapse m-2">


En balise alt, je mettrais plutôt un truc du style : alt="{% blocktrans with video_title=video.title %}QR code to access the video “{{ video_title }}”{% endblocktrans %}

pampletousse · 2024-01-23T07:48:48Z

Branche rebased sur develop, conservation de l'ancien qrcode d'édition rapide d'un évènement, ajout d'un QRCode de lecture (lien direct) vers event, basé sur le même principe que celui de vidéo.

@AymericJak pour les traductions _("QR code event's link") et _("QR code video's link") te conviennent ou tu préfères "QR code to access the video" / event ?

AymericJak · 2024-01-23T08:23:59Z

@AymericJak pour les traductions _("QR code event's link") et _("QR code video's link") te conviennent ou tu préfères "QR code to access the video" / event ?

J'étais plutôt de l'avis d'être plus précis que ça, quel est ton avis sur le sujet @Badatos ?

Badatos · 2024-01-23T08:28:56Z

@AymericJak pour les traductions _("QR code event's link") et _("QR code video's link") te conviennent ou tu préfères "QR code to access the video" / event ?

J'étais plutôt de l'avis d'être plus précis que ça, quel est ton avis sur le sujet @Badatos ?

Ca dépend du contexte ^^.
Une chose en tout cas : il faut être constant, et ne pas avoir de temps en temps "Download qrcode" et d'autre fois "QR code to access the video" => toujours utiliser 'QR code' plutôt que "qrcode" par exemple

pod/live/templates/live/event-info.html

Badatos · 2024-01-23T08:33:30Z

pod/video/templates/videos/video-info.html

+                <label>{% trans 'QR code for this link:' %}&nbsp;</label><br>
+                {{ qrcode }}
+                <br>
+                  <button id="btnDownloadQrCode" type="submit" data-slug="{{ video.slug }}" class="btn btn-primary my-2" title="{% trans 'Download qrcode' %}">{% trans 'Download' %}</button>


idem, préférez "QR code" à "qrcode"

Badatos · 2024-01-23T08:35:42Z

ça dépend du contexte ^^.

Si le texte est dans un bouton, alors autant rester concis, mais si c'est dans un title ou dans un texte d'aide on peut se permettre d'être le plus précis possible en effet.

AymericJak · 2024-01-24T08:09:22Z

pod/live/templates/live/event-info.html

+                    <label>{% trans 'QR code for this link:' %}&nbsp;</label><br>
+                    {{ qrcode }}
+                    <br>
+                      <button id="btnDownloadQrCode" type="submit" data-slug="{{ event.slug }}" class="btn btn-primary my-2" title="{% trans 'Download this QR code' %}">{% trans 'Download' %}</button>


Pour les identifiants, pourrais-tu appliquer la convention de nommage suivante : id="btn-download-qr-code"

AymericJak · 2024-01-24T08:13:18Z

pod/locale/fr/LC_MESSAGES/django.po

+msgid "QR code event's link"
+msgstr "QR code pour le lien de l'évènement :"


Petit problème de trad. Il manque les : le id

AymericJak · 2024-01-24T08:21:15Z

pod/locale/fr/LC_MESSAGES/django.po

+msgid "QR code video's link"
+msgstr "QR code pour le lien de la vidéo :"


Pareil, petit problème

AymericJak · 2024-01-24T08:27:09Z

pod/main/utils.py

@@ -101,3 +110,37 @@ def secure_post_request(request):
            request, messages.WARNING, _("This view cannot be accessed directly.")
        )
        raise PermissionDenied
+
+
+def generate_qrcode(url, id, alt, request=None):


Peux-tu ajouter les types pour les paramètres et le retour.

Dans l'en-tête, entre les parenthèses ? Car dans la pydoc pour moi c'est bon j'ai fait comme je l'ai trouvé ailleurs dans le code

AymericJak · 2024-01-24T08:28:24Z

pod/video/templatetags/video_tags.py

@@ -122,6 +124,13 @@ def get_last_videos(context):
    return recent_vids


+@register.simple_tag(name="get_video_qrcode")
+def get_video_qrcode(video_id):


Pareil pour le typage

pod/live/templates/live/event-info.html

AymericJak · 2024-01-24T14:06:24Z

pod/live/templatetags/event_tags.py

+
+
+@register.simple_tag(name="get_event_qrcode")
+def get_event_qrcode(event_id: int):


Peux tu spécifier le type de retour aussi : def get_event_qrcode(event_id: int)->str:

AymericJak · 2024-01-24T14:06:44Z

pod/video/templatetags/video_tags.py

@@ -122,6 +124,21 @@ def get_last_videos(context):
    return recent_vids


+@register.simple_tag(name="get_video_qrcode")
+def get_video_qrcode(video_id: int):


Pareil il faudrait le type de retour

pod/main/utils.py

Badatos

Juste une question sur des guillemets manquants, sinon c'est ok pour moi :)

AymericJak

Et c'est bon pour moi !
Thanks

SebastienCozeDev

Parfait niveau code pour moi. Merci !

ptitloup

ok pour moi

commit 3251cfd Author: github-actions <[email protected]> Date: Thu Jan 25 09:47:54 2024 +0000 Fixup. Format code with Prettier commit 9a492e4 Author: pampletousse <[email protected]> Date: Thu Jan 25 10:47:32 2024 +0100 [DONE] Pampletousse/feature download qrcode (EsupPortail#1015) * Add download button for qr code + fix border red too big * Mutualize qrcode generation and display between video and live(event) * Add same template modification to live event * Try to mutualize qr code generation between video and event * Add event slug to downloaded file name * éAdd alternative text to parameters * PEP8 conformity * Fix PEP8 E303 blank line * Fix PEP8 F811 * Uniformize QR code designation * Generate translations for QR Code managment * éAdd types into functions and doc + normalize id in template * Fix translations * Fix translation video into event in event-info template * Delete fuzzy translations * Add return types on functions in register tags (video and event) * Add quotes for alt in qr code img tag --------- Co-authored-by: pampletousse <[email protected]>

commit e374e46 Author: github-actions <[email protected]> Date: Fri Jan 26 15:18:20 2024 +0000 Fixup. Format code with Black commit 3a70723 Author: github-actions <[email protected]> Date: Fri Jan 26 15:18:12 2024 +0000 Fixup. Format code with Prettier commit 9e5068a Author: Aymeric Jakobowski <[email protected]> Date: Fri Jan 26 16:17:46 2024 +0100 [DONE] Bugfixes & improvements - 3.5.0 (EsupPortail#1023) * Fix dashboard styles * Fix dashboard translation * Modify Twitter icon & improve chapter style * Fix plural translations & z-index * Improve accessibility * Fix channels & some improvements * Fix dressing form * Fix roles optgroup * Update Pillow & sorl-thumbnail * Add some unit tests commit b229dad Author: github-actions <[email protected]> Date: Fri Jan 26 09:16:52 2024 +0000 Fixup. Format code with Black commit b3a583c Author: Valentin Sabatier <[email protected]> Date: Fri Jan 26 10:16:09 2024 +0100 [DONE] fix_for_video_dressing (EsupPortail#1029) * fixes * fix for pr qr code * remove fuzzy trad * fix lang commit 3251cfd Author: github-actions <[email protected]> Date: Thu Jan 25 09:47:54 2024 +0000 Fixup. Format code with Prettier commit 9a492e4 Author: pampletousse <[email protected]> Date: Thu Jan 25 10:47:32 2024 +0100 [DONE] Pampletousse/feature download qrcode (EsupPortail#1015) * Add download button for qr code + fix border red too big * Mutualize qrcode generation and display between video and live(event) * Add same template modification to live event * Try to mutualize qr code generation between video and event * Add event slug to downloaded file name * éAdd alternative text to parameters * PEP8 conformity * Fix PEP8 E303 blank line * Fix PEP8 F811 * Uniformize QR code designation * Generate translations for QR Code managment * éAdd types into functions and doc + normalize id in template * Fix translations * Fix translation video into event in event-info template * Delete fuzzy translations * Add return types on functions in register tags (video and event) * Add quotes for alt in qr code img tag --------- Co-authored-by: pampletousse <[email protected]> commit 0da5a2a Author: pampletousse <[email protected]> Date: Mon Jan 22 09:22:11 2024 +0100 [DONE] Pampletousse/fix dashboard translation (EsupPortail#1021) * Delete last calls to my_videos * Add missing translations in po file * Finish fix translations + compile * Add missing label on multiples actions * Change makefile and fix not used tranlations * Fix last tranlsation in pod/video/views.py * Fix last translation in pod/video/views.py * Add space on french translation --------- Co-authored-by: pampletousse <[email protected]> commit 37c4d62 Author: github-actions <[email protected]> Date: Wed Jan 17 10:57:11 2024 +0000 Fixup. Format code with Black commit 2db0640 Author: github-actions <[email protected]> Date: Wed Jan 17 10:57:02 2024 +0000 Fixup. Format code with Prettier commit 6b514d0 Author: pampletousse <[email protected]> Date: Wed Jan 17 11:56:36 2024 +0100 [DONE] Pampletousse/feature dashboard (EsupPortail#990) * Set new view to work on dashboard / cohabitation with old my_videos template = new template html, add corresponding url and view * Create Fetch request to bulk update videos * add value and action to post fetch request, udpate back method to validate value and split delete to update * backend dynamically update videos field even on ForeignKey objects or ManyToMany objects * create getSelectableVideos function to reusability, add and externalize select videos list and cards, delete count videos on dashboard front * Fix sort videos method after develop update * Change form to dynamic modelForm append async, clean code, rename create_with_fields form function * Create form into dashboard html, delete dashboard_form view and templates, manage multiple selected options to send, delete instance id condition to date_delete field add comments * Centralize view and treatment in one view (dashboard), fix videos list refresh, manage persistence of selected videos, improve user experience, improve video_select to mutualize it, add tooltip for selected videos * Repair checkboxes values to send for bulk_update, precise filters inputs selector for refresh, use owner_filter in dashboard, etc * Reorder options in dahboard form, manage restricted access and channel_option fieldsets * Refactoring code, change backend treatment to modelForm, manage generic fieldset * Offer 2 display modes : grid and list with dynamic templates, clean css, fix infinite and sorted/filtered videos * Improve list display mode, fix bugs, change links to btns for toggle display mode * Clean css, refactor code and fix item selected when click button or link * Fix categories (base url) * Change link my_videos to dashboard in navbar, fix display of thumbnail list mode * Add padding left to title row video list display mode * Fix grid mode thumbnails display * Add specific class to grid video list container * Fix auto checked inputs with get parameters + change label dashboard in navbar * Add translation (in template), fix bad translation for fr version of '%(counter)s video' * Add more translations, change label of modal confirm * Adjust permissions for multiple actions * Rename form + add links for django select2 * Fix owner multiple edit which needs video field for save * Try to fix video removal on owner update * Fix multiple edit owner, again * Fix and factorize video deletion, manage deletion and transcript on bulk update, change occurence of My videos into Dashboard * Delete unused imports, try to fix flake8 compilance -> dashboard post become bulk_update stand alone function * Fix pep8 indentation for django views object * Try to fix pep8 again * Fix Playlist test cause of new class added on icon * Add pydoc, add jsdoc, fix Tableau de bord trad rename selectedVideoCards -> selectedVideos * Add advanced_options fieldset to actions + Change order to dismiss confirm modal * Add aria-hidden true on all new i tags, change Dashboard into trans Dashboard, change all titles attributes double quotes into simple quotes * Add selected videos list to modal confirm bulk update * Mutualize fieldset collapse inputs (restricted access when is draft) * Manage errors feedback, improve code organisation, fix bugs, add generic functions dismiss_stored_messages and manageDisableBtns * Add visually hidden class text with icons * Add update_action parameter, try to fix PEP8, reformat code * Try to fix pep8 conformity * Add Exception to pep8 conformity * Delete unused imports in video.views.py * Fix translation problems and add new fr strings * Fix indentation in video.views.py * add coma for feedback message * PEP8 delete white line * Fix translations problems * Fix description case update not working (ckeditor value missing on formdata sent) * Fix reviews comments : Code refactor, rename, add pydoc, etc * Try to fix not working infinite more and loading links with new class d-none instead of style display none * Re-set old behaviour for infinite more link and diplay it * Change translation for you have not uploaded any videos + delete my_videos template * Add missing value affectation for default updated field * Try to fix mulitple transcription with new receiver * Fix selected videos conservation between diplay modes, sort and filters * Correctly return updated_videos * Change loader to bootstrap loader, improve user experience * Add condition to get bulk transcript message * Add pydoc on receivers and end line on loader.html * Fix slugs->titles display, improve confirmation modal, add translation for confirm modal * Remove unecessary tooltip on apply btn, change colors on countSelectedVideosBadge * Use ngettext on js translations * Fix new translations files * Fix missing js translation * am * Change translations files * Remove important unused, fix span in i tags on card_select, change title tag modale * Uniformize loader (bootstrap loader-spinner) on all views + delete old one * Fix accessibility on video_row_select.html * Manage active / inactive description for list display mode icons + delete unused webkit css + fix accessiblility on row_select * Add doc file on js files + change list to set into video.form.create_with_fields * Fix translations with makelang * Add end line loader.html * Fix accessiblity : dissociate loader and apply btn + fix selected videos * Add pydoc on new video tag and add version on video_select.js call * Change pydoc declaration for video model instance and class * Change translation for bbb dashboard * Fix div into li + translate close in showDashboardFormError * Fix accessibility of icons in card_select * éFinalize accessiblity * ÃFinalize accessiblity try again * Fix translation files --------- Co-authored-by: pampletousse <[email protected]> commit 2e9c4aa Author: github-actions <[email protected]> Date: Wed Jan 17 10:29:52 2024 +0000 Fixup. Format code with Black commit 3c3e4c7 Author: github-actions <[email protected]> Date: Wed Jan 17 10:29:44 2024 +0000 Fixup. Format code with Prettier commit e205b21 Author: Valentin Sabatier <[email protected]> Date: Wed Jan 17 11:29:19 2024 +0100 [DONE] Feature dressing video (EsupPortail#1006) * feature_dressing_video * make lang * flake * unit test + pydoc * Unit tests * fix dark theme * some fixes * Create migrations/__init__.py * fix encode when add watermark only * fix * Remove field site * add tests for dressing utilities * fix * Replace css by bootstrap classes * add table-sm * Use path instead url * fix * fix flake * remove id watermark * fix * fix flake * fix * fix panel admin * fix flake * [DONE] Patch elasticsearch options (EsupPortail#1009) * Update configuration.json * Update views.py * Update utils.py * Auto-update configuration files * [DONE] Feature import external video, add mediacad platform (EsupPortail#1014) * Add documentation about video platforms * Add tests * Add functions to manage import videos from Mediacad platform, and refactor some code * Add functions to manage import videos from Mediacad platform; improved error message handling * Add translations about Pod informations and Mediacad platform * Modification of a test due to improved error message handling * Add translations about Pod informations and Mediacad platform * Add translations about Pod informations and Mediacad platform * Change translation : Impossible to upload to Pod the video => Unable to upload the video to Pod; and remove fuzzy translations * Add role='alert' to one error message * Fixup. Format code with Black * [DONE] Fix jsi18n (EsupPortail#1011) * * Replace every `<script src="/admin/jsi18n/"></script>` by `<script id="jsi18n" src="{% url 'javascript-catalog' %}"></script>` * Add js-catalog in theme_edit.html * Add jsi18n in more scripts * Add JS catalog in caption maker * Remove every `javascript-catalog` as it is already in base.html * rename i18njs as jsi18n * Remove the "version" number in base html, as webpush also load it without version number and we do not want it to be downloaded twice. * [WIP] Fix CSS z-index for audio enrichment slide to keep them over the sound wave element (EsupPortail#1013) * Update views.py * 🐛 Fix z-index in audio enrichment to keep enrichement slides over the sound wave element --------- Co-authored-by: Ptitloup <[email protected]> * Fixup. Format code with Prettier * make lang * some fixes * fix lang * improve test settigns to add use docker setting - default to true (EsupPortail#1019) * Fixup. Format code with Black * [DONE] WebTV - Add private field (EsupPortail#1016) * init * trad * compil trad * fix * make lang * some fixes * fix * fix * [DONE] Feature import external video, add mediacad platform (EsupPortail#1014) * Add documentation about video platforms * Add tests * Add functions to manage import videos from Mediacad platform, and refactor some code * Add functions to manage import videos from Mediacad platform; improved error message handling * Add translations about Pod informations and Mediacad platform * Modification of a test due to improved error message handling * Add translations about Pod informations and Mediacad platform * Add translations about Pod informations and Mediacad platform * Change translation : Impossible to upload to Pod the video => Unable to upload the video to Pod; and remove fuzzy translations * Add role='alert' to one error message * Fixup. Format code with Black * make lang * some fixes * fix lang * conflits lang * compilemessages * fix * fix completion * fix * lang * fix * change Agreement required --------- Co-authored-by: PierreC <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Loïc Bonavent <[email protected]> Co-authored-by: Olivier Bado-Faustin <[email protected]> Co-authored-by: gcondess <[email protected]> Co-authored-by: Ptitloup <[email protected]> commit 6eda22a Author: github-actions <[email protected]> Date: Tue Jan 16 09:05:29 2024 +0000 Fixup. Format code with Black commit d79ba51 Author: Ptitloup <[email protected]> Date: Tue Jan 16 10:04:55 2024 +0100 [DONE] Ptitloup/improve subtitle accessibility (EsupPortail#1018) * create improveCaptionsAccessibility and call it before saving webvtt file to improve accessibility of subtitle * remove trailing whitespace * add js function to add choosing lang to transcript video and hide button if no language choosen * add the specified language to the video before launch trancsript * add some pydoc in the news functions - use same function to convert to timestamps * add pydoc in good format commit 519aaf9 Author: Valentin Sabatier <[email protected]> Date: Mon Jan 15 15:28:06 2024 +0100 [DONE] WebTV - Add private field (EsupPortail#1016) * init * trad * compil trad * fix commit b120fe9 Author: github-actions <[email protected]> Date: Thu Jan 11 16:25:48 2024 +0000 Fixup. Format code with Black commit 1c74d70 Author: Ptitloup <[email protected]> Date: Thu Jan 11 17:25:23 2024 +0100 improve test settigns to add use docker setting - default to true (EsupPortail#1019)

ptitloup requested changes Dec 18, 2023

View reviewed changes

SebastienCozeDev suggested changes Jan 4, 2024

View reviewed changes

AymericJak suggested changes Jan 4, 2024

View reviewed changes

Badatos assigned pampletousse Jan 15, 2024

pampletousse force-pushed the pampletousse/feature-download_qrcode branch from 44ab7f1 to 271e38f Compare January 23, 2024 07:45

pampletousse changed the title ~~[DONE] Pampletousse/feature download qrcode~~ [WIP] Pampletousse/feature download qrcode Jan 23, 2024

Badatos self-requested a review January 23, 2024 08:29

Badatos requested changes Jan 23, 2024

View reviewed changes

AymericJak suggested changes Jan 24, 2024

View reviewed changes

pampletousse added 10 commits January 24, 2024 09:40

Add download button for qr code + fix border red too big

8e2163f

Mutualize qrcode generation and display between video and live(event)

f603b50

Add same template modification to live event

1de47d6

Try to mutualize qr code generation between video and event

cf0d829

Add event slug to downloaded file name

6947a0c

éAdd alternative text to parameters

9328e06

PEP8 conformity

568d27c

Fix PEP8 E303 blank line

dfbd133

Fix PEP8 F811

17bcd9d

Uniformize QR code designation

8548994

pampletousse force-pushed the pampletousse/feature-download_qrcode branch from e6d5b8b to 8548994 Compare January 24, 2024 08:44

dsim added 3 commits January 24, 2024 09:46

Generate translations for QR Code managment

3f36498

éAdd types into functions and doc + normalize id in template

0e3fa0d

Fix translations

9b49e79

pampletousse changed the title ~~[WIP] Pampletousse/feature download qrcode~~ [DONE] Pampletousse/feature download qrcode Jan 24, 2024

mattbild reviewed Jan 24, 2024

View reviewed changes

pod/live/templates/live/event-info.html Outdated Show resolved Hide resolved

Fix translation video into event in event-info template

8e52dfb

Delete fuzzy translations

30f1ce3

AymericJak suggested changes Jan 24, 2024

View reviewed changes

Add return types on functions in register tags (video and event)

add2cc3

Badatos reviewed Jan 24, 2024

View reviewed changes

pod/main/utils.py Outdated Show resolved Hide resolved

Add quotes for alt in qr code img tag

15b2e69

Badatos approved these changes Jan 24, 2024

View reviewed changes

AymericJak approved these changes Jan 24, 2024

View reviewed changes

SebastienCozeDev approved these changes Jan 25, 2024

View reviewed changes

ptitloup approved these changes Jan 25, 2024

View reviewed changes

ptitloup merged commit 9a492e4 into EsupPortail:develop Jan 25, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DONE] Pampletousse/feature download qrcode #1015

[DONE] Pampletousse/feature download qrcode #1015

pampletousse commented Dec 18, 2023

ptitloup left a comment

ptitloup Dec 18, 2023

AymericJak Jan 4, 2024

pampletousse Jan 9, 2024

ptitloup Dec 18, 2023

ptitloup Dec 18, 2023

SebastienCozeDev left a comment

SebastienCozeDev Jan 4, 2024

AymericJak left a comment

AymericJak Jan 4, 2024

AymericJak Jan 4, 2024

pampletousse commented Jan 23, 2024

AymericJak commented Jan 23, 2024

Badatos commented Jan 23, 2024

Badatos Jan 23, 2024

Badatos commented Jan 23, 2024 •

edited

Loading

AymericJak Jan 24, 2024

AymericJak Jan 24, 2024

AymericJak Jan 24, 2024

AymericJak Jan 24, 2024

pampletousse Jan 24, 2024

AymericJak Jan 24, 2024

AymericJak Jan 24, 2024

AymericJak Jan 24, 2024

Badatos left a comment

AymericJak left a comment

SebastienCozeDev left a comment

ptitloup left a comment

		msgid "QR code event's link"
		msgstr "QR code pour le lien de l'évènement :"

		msgid "QR code video's link"
		msgstr "QR code pour le lien de la vidéo :"



		@register.simple_tag(name="get_event_qrcode")
		def get_event_qrcode(event_id: int):

[DONE] Pampletousse/feature download qrcode #1015

[DONE] Pampletousse/feature download qrcode #1015

Conversation

pampletousse commented Dec 18, 2023

ptitloup left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SebastienCozeDev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AymericJak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pampletousse commented Jan 23, 2024

AymericJak commented Jan 23, 2024

Badatos commented Jan 23, 2024

Choose a reason for hiding this comment

Badatos commented Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Badatos left a comment

Choose a reason for hiding this comment

AymericJak left a comment

Choose a reason for hiding this comment

SebastienCozeDev left a comment

Choose a reason for hiding this comment

ptitloup left a comment

Choose a reason for hiding this comment

Badatos commented Jan 23, 2024 •

edited

Loading