Skip to content

Commit

Permalink
éAdd alternative text to parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
pampletousse authored and pampletousse committed Jan 23, 2024
1 parent f8c5f10 commit 271e38f
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 7 deletions.
3 changes: 2 additions & 1 deletion pod/live/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@ def is_recording_admin(self):

@property
def qrcode(self, request=None):
return generate_qrcode("live:event_immediate_edit", self.id, request)
alt = _("QR code to record immediately an event")
return generate_qrcode("live:event_immediate_edit", self.id, alt, request)

def set_broadcaster_file(self, filename):
trans_folder = os.path.join(MEDIA_ROOT, LIVE_TRANSCRIPTIONS_FOLDER)
Expand Down
5 changes: 4 additions & 1 deletion pod/live/templatetags/event_tags.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
from django.template.defaultfilters import register
from django.utils import timezone

from django.utils.translation import ugettext_lazy as _
from pod.live.models import Event
from pod.live.views import can_manage_event
from pod.main.utils import generate_qrcode



@register.simple_tag(takes_context=True)
def get_next_events(context, broadcaster_id=None, limit_nb=4):
request = context["request"]
Expand All @@ -29,4 +31,5 @@ def can_manage_event_filter(user):
@register.simple_tag(name="get_event_qrcode")
def get_event_qrcode(event_id):
"""Get the event generated QR code."""
return generate_qrcode("live:event_immediate_edit", event_id)
alt = _("QR code event's link")
return generate_qrcode("live:event_immediate_edit", event_id, alt)
6 changes: 3 additions & 3 deletions pod/main/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,14 @@ def secure_post_request(request):
raise PermissionDenied


def generate_qrcode(url, id, request=None):
def generate_qrcode(url, id, alt, request=None):
"""
Generate qrcode for live event or video share link
Args:
url (string): Url corresponding to link
id (number): Id of object
id (number): Identifier of object
alt (string): Translated string for alternative text
request (Request): HTTP Request
Returns:
Expand All @@ -138,7 +139,6 @@ def generate_qrcode(url, id, request=None):
buffer = io.BytesIO()
img.save(buffer, format="PNG")
img_str = base64.b64encode(buffer.getvalue()).decode("utf-8")
alt = _("QR code to record immediately an event")
return mark_safe(
f'<img id="qrcode" src="data:image/png;base64, {img_str}" '
+ f'width="200px" height="200px" alt={alt}>'
Expand Down
1 change: 0 additions & 1 deletion pod/video/templates/videos/video-info.html
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ <h2 class="modal-title h3" id="shareLabel">
<button id="btnDownloadQrCode" type="submit" data-slug="{{ video.slug }}" class="btn btn-primary my-2" title="{% trans 'Download qrcode' %}">{% trans 'Download' %}</button>
</div>
</fieldset>

</div>
</div>
</div>
Expand Down
3 changes: 2 additions & 1 deletion pod/video/templatetags/video_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ def get_last_videos(context):
@register.simple_tag(name="get_video_qrcode")
def get_video_qrcode(video_id):
"""Get the video generated QR code."""
return generate_qrcode("enrichment:video_enrichment", video_id)
alt = _("QR code video's link")
return generate_qrcode("enrichment:video_enrichment", video_id, alt)


@register.simple_tag(name="get_video_infos")
Expand Down

0 comments on commit 271e38f

Please sign in to comment.