WGPU example #92

VZout · 2020-10-22T10:49:12Z

Up to y'all if you want this in.
Just copy pasted the wgpu example and made it rusty.

Mainly just wrote it so I can patch it into main locally for testing.

Fix #65

khyperia · 2020-10-22T11:44:06Z

oh my gosh, I can actually, read the entire example-runner program without my eyes glazing over, that's incredible

VZout · 2020-10-22T11:46:17Z

Not only that it also runs in the browser!

expenses · 2020-10-22T18:52:01Z

The Cargo.toml for the runner seems to be out of date with main.rs because wasm-bindgen-futures isn't listed as a dependency.

repi · 2020-10-22T18:54:33Z

Wait we don't need a different shader right? Can just use the same one.

And then maybe call it example-runner-wgpu and example-runner-ash?

DJMcNab · 2020-10-22T21:09:53Z

I've mostly made it work with the old shader in https://github.com/DJMcNab/rust-gpu/tree/wgpu-example, although the output I get is upside down. I'm not sure why that is 🤔.

Thanks to the people on the discord for helping me get it this far.

VZout · 2020-10-22T21:12:59Z

Wait we don't need a different shader right? Can just use the same one.

And then maybe call it example-runner-wgpu and example-runner-ash?

We don't but I made this more for myself since I want a tiny as possible shader for my own testing. This I can just patch into my branches and test/debug easily.

Cargo.toml

* Fixed nested if statements * feedback * Removed a line

* Add bug report template * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Ari V <[email protected]> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Ari V <[email protected]> * Update bug_report.md * Update bug_report.md Co-authored-by: Ari V <[email protected]>

This should mean that if one of the required components is broken on a given nightly, rustup will try going backwards until it finds one which works.

* Initial commit for binding proposal, nees some cleanup * Continue at home * Explain global binding model * Explain function binging model * Final suggestion * Add more ups & downs * Add another downside to static * Add another downside to static

This reverts commit 985ae7d.

repi · 2020-10-24T20:26:06Z

On my Windows machine the wgpu-example-runner example works, but on my Mac I just get the following when running which is rather odd:

[0.902503 ERROR]()(no module): Function retrieval error "Function \'main_vs\' does not exist"
[0.902600 ERROR]()(no module): Invalid shader entry point 'main_vs': InvalidEntryPoint
thread 'main' panicked at 'failed to create graphics pipeline: Failed to create pipeline: Unsupported usage: Implementation specific error occurred', /Users/johan/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-core-0.6.5/src/device/mod.rs:2898:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Not really sure at all why it would be failing to find even the entrypoint of the shader

grovesNL · 2020-10-24T20:36:21Z

@repi this seems to be a bug, we'll fix it in gfx-rs/gfx#3435

grovesNL · 2020-10-27T00:24:55Z

@repi we just published a patch release, so this should work fine after updating with cargo update or cargo update -p gfx-backend-metal

repi · 2020-10-27T00:28:45Z

@grovesNL awesome thx, will try out!

Update: worked!

repi

Works with Mac now, yay! And merged it with the latest changes.

Think we should get this in! And once it is merged we could do some renaming & moving things around a bit.

Co-authored-by: bjorn3 <[email protected]>

fu5ha · 2020-10-27T01:21:13Z

Cargo.toml

    "examples/example-shader",
+    "examples/wgpu-example-shader",


Adding a comment here, one thing that I would change but I think could be done after merging, is to rename this shader to something like hello-world-shader or simplest-shader or something to that effect, since it shouldn't really be specific to wgpu.

fully agree!

I was thinking that the current example-shader would become more, well simply, shaders with a set of non-trivial shaders like the current sky one and more in the same crate.

but also very good then to have a super simple separate crate that is easier to iterate on with fewer dependencies and features. esp. soon when glam gets in #149

fu5ha

With the caveat of my one comment, think this seems fine to merge for now... I can take stewardship of making this a little more integrated with the other example(s) afterwards. I would like to get #109 merged as well which then paves the way for the wgpu runner to run the sky example.

khyperia · 2020-10-27T08:09:59Z

.github/workflows/ci.yaml

@@ -46,6 +46,7 @@ jobs:
    steps:
      - uses: actions/checkout@v2
      - run: sudo apt install libwayland-cursor0 libxkbcommon-dev libwayland-dev
+      - run: brew install spirv-tools


wait what? this should have excluded wgpu-example-runner in the clippy run, not installing spirv-tools, right? either that or including example-runner in the clippy run

not sure what you mean?

Did get clippy build failures on this branch on that spirv-tools was missing

Why would you use brew on a linux job?

@bjorn3 It's the only package manager with spirv-tools on linux that is available in GitHub Actions.

Why would you use brew on a linux job?

See also #107

WGPU Examples

d8a0210

VZout force-pushed the wgpu-example branch from ac26d76 to d8a0210 Compare October 22, 2020 21:17

fu5ha mentioned this pull request Oct 23, 2020

Cleanup pass on example shader and vk example-runner #109

Merged

bjorn3 reviewed Oct 23, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

VZout and others added 16 commits October 24, 2020 00:00

README (#94)

2634962

Remove mentions of the triangle

f91d822

Update README.md

9068cdd

Fixed nested if statements (#88)

fa4489b

* Fixed nested if statements * feedback * Removed a line

README tweaks for first release (#96)

2401c1a

If statement (#98)

baa49ce

Use the --component option in setup scripts (#104)

dba1be4

This should mean that if one of the required components is broken on a given nightly, rustup will try going backwards until it finds one which works.

Fix mergify branch

c7a0130

Move panic_handler and eh_personality to spirv-std (#95)

867ec17

Bindings proposal (#19)

928e96f

* Initial commit for binding proposal, nees some cleanup * Continue at home * Explain global binding model * Explain function binging model * Final suggestion * Add more ups & downs * Add another downside to static * Add another downside to static

Revert "Move panic_handler and eh_personality to spirv-std (#95)"

ba7a62b

This reverts commit 985ae7d.

Merge branch 'main' into wgpu-example

f601b3f

[wgpu-example] Remove unused ash-molten dependency

d607464

Disable tests for wgpu shader as well

6fc3a12

Merge branch 'main' into wgpu-example

0d7c656

repi added 4 commits October 27, 2020 01:36

Update to latest gfx crates to fix Metal bug

f6a7f44

Merge branch 'main' into wgpu-example

4a4e5da

Fixup shader with latest spriv attribute

e109393

cargo-deny fixes

d8e79d7

repi requested a review from fu5ha October 27, 2020 01:01

repi approved these changes Oct 27, 2020

View reviewed changes

repi and others added 2 commits October 27, 2020 02:14

Update Cargo.toml

609ed55

Co-authored-by: bjorn3 <[email protected]>

Fix CI so clippy step includes spirv-tools

dfb0d92

fu5ha reviewed Oct 27, 2020

View reviewed changes

fu5ha approved these changes Oct 27, 2020

View reviewed changes

repi merged commit 27df71f into main Oct 27, 2020

repi deleted the wgpu-example branch October 27, 2020 01:39

khyperia reviewed Oct 27, 2020

View reviewed changes

expenses mentioned this pull request Oct 27, 2020

Fix compling the wgpu-example-runner on wasm32-unknown-unknown #159

Merged

khyperia mentioned this pull request Jun 21, 2021

Upgrade wgpu #676

Merged

WGPU example #92

WGPU example #92

Uh oh!

Conversation

VZout commented Oct 22, 2020 • edited by repi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khyperia commented Oct 22, 2020

Uh oh!

VZout commented Oct 22, 2020

Uh oh!

expenses commented Oct 22, 2020

Uh oh!

repi commented Oct 22, 2020

Uh oh!

DJMcNab commented Oct 22, 2020

Uh oh!

VZout commented Oct 22, 2020

Uh oh!

Uh oh!

repi commented Oct 24, 2020

Uh oh!

grovesNL commented Oct 24, 2020

Uh oh!

grovesNL commented Oct 27, 2020

Uh oh!

repi commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repi left a comment

Choose a reason for hiding this comment

Uh oh!

fu5ha Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

repi Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

fu5ha left a comment

Choose a reason for hiding this comment

Uh oh!

khyperia Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

repi Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

bjorn3 Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

XAMPPRocky Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

khyperia Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VZout commented Oct 22, 2020 •

edited by repi

Loading

repi commented Oct 27, 2020 •

edited

Loading