Skip to content

Conversation

DJMcNab
Copy link
Contributor

@DJMcNab DJMcNab commented Jun 19, 2021

Wgpu 0.9 has released, now under MIT/Apache 2.0 🎉

We can't remove MPL-2.0 from the deny.toml, because wgpu_subscriber is still under MPL.

DJMcNab added 2 commits June 19, 2021 11:25
We can't remove MPL from the deny.toml yes, as wgpu-subscriber
is still MPL
@DJMcNab DJMcNab requested review from khyperia, fu5ha and VZout as code owners June 19, 2021 10:26
@DJMcNab
Copy link
Contributor Author

DJMcNab commented Jun 19, 2021

I've also tried to enable validation again, without success

Naga still chokes on our compute shader, with exceedingly unhelpful error messages.

DJMcNab added 2 commits June 19, 2021 15:43
This also does let us remove MPL-2.0

As of EmbarkStudios#674, the crate of the
advisory is no longer in our tree
@khyperia
Copy link
Contributor

@VZout I vaguely recall there was a reason you used wgpu-subscriber instead of env_logger in #92, am I misremembering and this change is fine, or is there a reason?

@DJMcNab
Copy link
Contributor Author

DJMcNab commented Jun 21, 2021

I think wgpu moved to just log in gfx-rs/wgpu#1211 (comment)

});
timestamp_buffer.unmap();
Copy link
Member

@VZout VZout Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why map during creation and then immediately unmap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's required to actually get values from the queries - there's a wgpu issue about it, which I can't find at the moment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VZout
Copy link
Member

VZout commented Jun 23, 2021

@VZout I vaguely recall there was a reason you used wgpu-subscriber instead of env_logger in #92, am I misremembering and this change is fine, or is there a reason?

The reason we used wgpu-subscriber was because back then the triangle example in the wgpu repo used wgpu-subscriber. I'm not aware of any other reason. I think env logger is better anyway. gives you pretty colors. (And I get the feeling subscriber is abandoned?)

@khyperia khyperia merged commit 7974817 into EmbarkStudios:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants