-
Notifications
You must be signed in to change notification settings - Fork 246
Upgrade wgpu #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wgpu #676
Conversation
We can't remove MPL from the deny.toml yes, as wgpu-subscriber is still MPL
I've also tried to enable validation again, without success Naga still chokes on our compute shader, with exceedingly unhelpful error messages. |
This also does let us remove MPL-2.0 As of EmbarkStudios#674, the crate of the advisory is no longer in our tree
I think wgpu moved to just log in gfx-rs/wgpu#1211 (comment) |
}); | ||
timestamp_buffer.unmap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why map during creation and then immediately unmap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's required to actually get values from the queries - there's a wgpu issue about it, which I can't find at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we used |
Wgpu 0.9 has released, now under MIT/Apache 2.0 🎉
We can't remove MPL-2.0 from the deny.toml, because wgpu_subscriber is still under MPL.