Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure RTW to use user configuration file from checked out version of ESMValTool #2840

Closed
wants to merge 7 commits into from
Closed

Configure RTW to use user configuration file from checked out version of ESMValTool #2840

wants to merge 7 commits into from

Conversation

KatherineTomkins
Copy link

@KatherineTomkins KatherineTomkins commented Oct 7, 2022 •
edited by ehogan
Loading

Description

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script

To help with the number of pull requests:

@KatherineTomkins KatherineTomkins linked an issue Oct 7, 2022 that may be closed by this pull request
Configure RTW to use config-user.yml from checked out version of ESMValTool #2839
Closed
@KatherineTomkins KatherineTomkins changed the base branch from main to recipe_test_workflow_prototype October 7, 2022 14:07
@KatherineTomkins KatherineTomkins self-assigned this Oct 7, 2022
@KatherineTomkins KatherineTomkins marked this pull request as draft October 7, 2022 14:54
@KatherineTomkins KatherineTomkins changed the title 2839 configure rtw to use config useryml from checked out version of esmvaltool #2839 configure rtw to use config useryml from checked out version of esmvaltool Oct 7, 2022
@KatherineTomkins KatherineTomkins changed the title #2839 configure rtw to use config useryml from checked out version of esmvaltool 2839 configure rtw to use config useryml from checked out version of esmvaltool Oct 7, 2022
@KatherineTomkins KatherineTomkins marked this pull request as ready for review October 7, 2022 15:38
mo-tgeddes
mo-tgeddes reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@mo-tgeddes mo-tgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KatherineTomkins I'm a bit confused on why you need still set the old user-config file path and write to it if its not getting used at all?

@KatherineTomkins
Copy link
Author

Hi @KatherineTomkins I'm a bit confused on why you need still set the old user-config file path and write to it if its not getting used at all?

I'll give you a call about this.

@KatherineTomkins KatherineTomkins added the Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow label Oct 13, 2022
mo-tgeddes
mo-tgeddes approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@mo-tgeddes mo-tgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks for explaining :)

@ehogan ehogan changed the title 2839 configure rtw to use config useryml from checked out version of esmvaltool Configure RTW to use config-user.yml from checked out version of ESMValTool Oct 17, 2022
@ehogan ehogan mentioned this pull request Oct 17, 2022
Closed
ehogan
ehogan requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@ehogan ehogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KatherineTomkins and @mo-tgeddes! :)

esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/app/configure/bin/configure.py Outdated
Comment on lines 31 to 32
# The dictionary is then updated with the path to the latest checked out
# version of config-user-example.yml from the ESMValTool directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to incorporate this comment into the comment above, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tricky - best effort so far in 2133c52

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is better I think: ba0222f

@ehogan ehogan changed the title Configure RTW to use config-user.yml from checked out version of ESMValTool Configure RTW to use user configuration file from checked out version of ESMValTool Oct 19, 2022
@ehogan
Copy link
Contributor

ehogan commented May 5, 2023

Closing this PR in favour of #3169.

@ehogan ehogan closed this May 5, 2023
@ehogan ehogan deleted the 2839-configure-rtw-to-use-config-useryml-from-checked-out-version-of-esmvaltool branch May 10, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-tgeddes mo-tgeddes mo-tgeddes approved these changes

@ehogan ehogan Awaiting requested review from ehogan

Assignees

@KatherineTomkins KatherineTomkins

Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure RTW to use config-user.yml from checked out version of ESMValTool
4 participants
@KatherineTomkins @ehogan @mo-tgeddes @katherinetomkins-mo