CCPPize Hack shallow convection #195
Conversation
…ter uses none as units
There was a problem hiding this comment.
Good work @jimmielin! I have some question and suggestions, but hopefully nothing too difficult. Of course if you have any issues or concerns with any of my requests just let me know. Thanks!
…state_diagnostics); comments
There was a problem hiding this comment.
Thanks for resolving most of my questions/concerns @jimmielin! I just had a few more questions, mostly related to missed comments from the previous review.
|
Thanks @nusbaume for the comments and suggestions! I believe I have resolved all of these now (except one question on ZM for @cacraigucar). |
There was a problem hiding this comment.
Thanks for implementing those final few suggestions @jimmielin! I left un-resolved the two questions that are waiting on other people's input, but neither of them is required. Thanks again!
| real(kind_phys),intent(in) :: zmconv_ke_lnd | ||
| real(kind_phys),intent(in) :: zmconv_momcu | ||
| real(kind_phys),intent(in) :: zmconv_momcd |
There was a problem hiding this comment.
Should these writes become part of the namelist generated code (a future issue)? It feels like it is too easy for the informational writes to get out-of-sync with the namelist generated code. As for the missing fields, it makes sense to have the namelist variables written out.
Also, mpi_bcast may need to be eventually added to the generated namelists, if they are not already being done. @peverwhee and @nusbaume - thoughts?
|
Thanks everyone for your reviews! CAM regression tests: all pass (excluding pre-existing failures) SIMA regression tests passed/baseline changes (will archive baselines once SIMA tag is merged.) hack_convect_shallow test physics check results |
Tag name (The PR title should also include the tag name): atmos_phys0_10_000 Originator(s): @jimmielin List all `development` PR numbers included in this PR and the title of each: * CCPPize Hack shallow convection #195 by @jimmielin * Update MUSICA index mapping API and CMake script #208 by @boulderdaze List all automated tests that failed, as well as an explanation for why they weren't fixed: * B4B for CAM * New baselines in CAM7/CAM4 in CAM-SIMA
Originator(s): @jimmielin
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
cmfmca) and related interstitialszm_conv_optionsscheme so not all of ZM has to run while ZM namelist options are read for zm_conv_evap (needed for complete shallow convection)kg m-2 s-1errmsg,errflgtocloud_fraction_ficesxhemetop_levincloud_fraction_ficeto a registry quantity that can be defined by macrophysics initializationm s-1Describe any changes made to the namelist:
cmfmca_namelist.xmlzm_conv_options_namelist.xmlList all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)List any test failures:
Is this a science-changing update? New physics package, algorithm change, tuning changes, etc?
New Hack shallow convection scheme