Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check cmflq (total_water_flux_due_to_shallow_convection) standard name #212

Open
jimmielin opened this issue Feb 26, 2025 · 2 comments
Assignees
Labels
cleanup This issue indicates an opportunity for code cleanup.

Comments

@jimmielin
Copy link
Member

jimmielin commented Feb 26, 2025

This issue arose during the review for Hack shallow convection CCPPization #195

@nusbaume wrote about the cmflq standard name:

Is this actually "total" water, or just water vapor and cloud liquid water? Technically cloud ice would be included in total_water but I don't think anything is actually done with ice within the hack scheme outside of the general constituent tendencies.

@jimmielin wrote:

I am not too sure about this. Some parts of the code explicitly state cloud liquid water, so maybe "total water" is intentional, but you are also correct that nothing is done with cloud ice except from convective transport. The units for cmflq are also W m-2 which is unusual so I am not sure if we want to revise the standard name.

Current definition

[ cmflq ]
  standard_name = total_water_flux_due_to_shallow_convection
  units = W m-2
  type = real | kind = kind_phys
  dimensions = (horizontal_loop_extent, vertical_interface_dimension)
  intent = out

defined as

        ! The following variables have units of w/m**2
        cmfsl (i,k+1) = cmfsl (i,k+1) + fslkp*adjfac
        cmfsl (i,k  ) = cmfsl (i,k  ) + fslkm*adjfac
        cmflq (i,k+1) = cmflq (i,k+1) + hlat*fqlkp*adjfac
        cmflq (i,k  ) = cmflq (i,k  ) + hlat*fqlkm*adjfac

Tagging @nusbaume and @adamrher for future discussion.

Thanks!

@jimmielin jimmielin added the cleanup This issue indicates an opportunity for code cleanup. label Feb 26, 2025
@jimmielin jimmielin self-assigned this Feb 26, 2025
@adamrher
Copy link

adamrher commented Feb 26, 2025

We had a similar issue with clubb's "total water" as clubb also neglects ice from its definition. We decided to be explicit on the definition in creating these standard names, e.g., pbuf_RTM (line 237 in CCPP standard name spreadsheet) is sum_of_water_vapor_and_cloud_liquid_mixing_ratio_wrt_dry_air.

We could similarly call cmflq sum_of_water_vapor_and_cloud_liquid_flux_due_to_shallow_convection.

@dwarddy2794

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup This issue indicates an opportunity for code cleanup.
Projects
Status: To Do
Development

No branches or pull requests

3 participants