Skip to content

Add endpoint to create a symlink on a directory#681

Merged
d-j-hatton merged 2 commits intomainfrom
symlinks
Oct 17, 2025
Merged

Add endpoint to create a symlink on a directory#681
d-j-hatton merged 2 commits intomainfrom
symlinks

Conversation

@d-j-hatton
Copy link
Contributor

This will allow symlinks to be created to destinations from the frontend

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.07%. Comparing base (e4b297a) to head (26dfdee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   35.04%   35.07%   +0.02%     
==========================================
  Files          91       91              
  Lines       11122    11142      +20     
  Branches     1479     1481       +2     
==========================================
+ Hits         3898     3908      +10     
- Misses       7097     7107      +10     
  Partials      127      127              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
Copy link
Contributor

tieneupin commented Oct 14, 2025

The function itself looks fine, but could you provide an example of how this is meant to be used in practice? Is this meant to enable, say, the client PC of instrument A to view datasets from instrument B?

@d-j-hatton
Copy link
Contributor Author

the industrial side have requested a mechanism to allow data paths that do not conform to our raw* naming scheme. the only real way to do this while still supporting immediate transfer of new directories is to allow symlinks to be created to the raw* directories. the destination path in the database for an rsyncer does not contain the rsync basepath so that has to be added on.

I'm thinking you would have an option to create a symlink from the rsyncer drop down in the frontend where you would enter the symlink path

@tieneupin
Copy link
Contributor

If I'm understanding correctly, this would mean that data will still be transferred to raw* by default, but there will now be additional symlinks in the visit directory associated with the different raw* directories that the user can assign more descriptive/memorable names to?

@d-j-hatton
Copy link
Contributor Author

yep that's right. and they may have some kind of transfer to cloud setup that assumes a certain naming scheme different to ours

Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, moves us closer to getting the industry team across to murfey properly

@d-j-hatton d-j-hatton merged commit d9c3e64 into main Oct 17, 2025
17 checks passed
@d-j-hatton d-j-hatton deleted the symlinks branch October 17, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants