Skip to content

Adjusted type hint for '_get_session()' #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tieneupin wants to merge 1 commit into from
Closed

Adjusted type hint for '_get_session()' #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/murfey/server/ispyb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import datetime
import logging
from typing import Callable, List, Literal, Optional
from typing import Callable, Generator, List, Literal, Optional

import ispyb

Expand Down Expand Up @@ -535,7 +535,7 @@ def do_buffer_lookup(self, app_id: int, uuid: int) -> Optional[int]:
return reference


def _get_session() -> sqlalchemy.orm.Session:
def _get_session() -> Generator[Optional[sqlalchemy.orm.Session], None, None]:
db = Session()
if db is None:
yield None
Expand Down