Skip to content

Adjusted type hint for '_get_session()'#555

Closed
tieneupin wants to merge 1 commit intomainfrom
type-hint-fix
Closed

Adjusted type hint for '_get_session()'#555
tieneupin wants to merge 1 commit intomainfrom
type-hint-fix

Conversation

@tieneupin
Copy link
Contributor

_get_session() can return either None or a Generator object that yields sqlalchemy.orm.Session or None. Updated the type hint to reflect that.

@tieneupin tieneupin added the documentation Improvements or additions to documentation label Apr 1, 2025
@tieneupin tieneupin self-assigned this Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.77%. Comparing base (84770ff) to head (c42a158).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   28.85%   28.77%   -0.09%     
==========================================
  Files          80       80              
  Lines       10556    10646      +90     
  Branches     1406     1439      +33     
==========================================
+ Hits         3046     3063      +17     
- Misses       7408     7478      +70     
- Partials      102      105       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin closed this Apr 8, 2025
@tieneupin
Copy link
Contributor Author

Same fix was included as part of PR #560 .

@tieneupin tieneupin deleted the type-hint-fix branch April 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant