Container setup for TEM workflow + tomography/SPA bugfixes#503
Merged
Container setup for TEM workflow + tomography/SPA bugfixes#503
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 28.64% 28.63% -0.01%
==========================================
Files 78 78
Lines 10226 10253 +27
Branches 1355 1359 +4
==========================================
+ Hits 2929 2936 +7
- Misses 7196 7216 +20
Partials 101 101 🚀 New features to boost your workflow:
|
…the EER fractionation file
…m MachineConfig in the demo API
…with the Analyser; added debug logs to track progress of Analyser
stephen-riggs
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up the Helm charts needed in order to create an instrument server container to test the TEM workflow with. Along the way, various bugs that were uncovered were also patched:
rsync_urlkey to theMurfeyInstanceEnvironmentclass, now that we are supporting externally run rsync daemonsinstrument_namefrom database lookup, instead of using theget_microscope()functionprepare_(eer_)gain()function to see why the subprocess failsfeedback_callbackfunction where no workflows are found