Skip to content

Container setup for TEM workflow + tomography/SPA bugfixes#503

Merged
tieneupin merged 18 commits intomainfrom
add-tem-instrument-server
Mar 11, 2025
Merged

Container setup for TEM workflow + tomography/SPA bugfixes#503
tieneupin merged 18 commits intomainfrom
add-tem-instrument-server

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Mar 5, 2025

This PR sets up the Helm charts needed in order to create an instrument server container to test the TEM workflow with. Along the way, various bugs that were uncovered were also patched:

  • Added an rsync_url key to the MurfeyInstanceEnvironment class, now that we are supporting externally run rsync daemons
  • Set microscope name using instrument_name from database lookup, instead of using the get_microscope() function
  • Added logs to the prepare_(eer_)gain() function to see why the subprocess fails
  • Fixed logic for why the first tomography position is not processed
  • Added logic to handle cases in the feedback_callback function where no workflows are found
  • Locked NumPy to <2 (NumPy compatibility will need to be addressed in future; see Fix use of NumPy in Murfey repo so that it works with both v1 and v2 #508 )

@tieneupin tieneupin self-assigned this Mar 5, 2025
@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 21.62162% with 29 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (0563c8d) to head (067c1d6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   28.64%   28.63%   -0.01%     
==========================================
  Files          78       78              
  Lines       10226    10253      +27     
  Branches     1355     1359       +4     
==========================================
+ Hits         2929     2936       +7     
- Misses       7196     7216      +20     
  Partials      101      101              
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin added the ci-cd Improvements to project development environment label Mar 5, 2025
@tieneupin tieneupin changed the title Added Helm charts to create an instrument server for TEM workflow Container setup for TEM workflow + Bugfixes Mar 6, 2025
@tieneupin tieneupin marked this pull request as ready for review March 7, 2025 17:18
@tieneupin tieneupin changed the title Container setup for TEM workflow + Bugfixes Container setup for TEM workflow + tomography bugfixes Mar 7, 2025
@tieneupin tieneupin changed the title Container setup for TEM workflow + tomography bugfixes Container setup for TEM workflow + tomography/SPA bugfixes Mar 11, 2025
@tieneupin tieneupin merged commit e8e361d into main Mar 11, 2025
17 checks passed
@tieneupin tieneupin deleted the add-tem-instrument-server branch March 11, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Improvements to project development environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants