Resolved client-server import chain and added installation key for instrument server dependencies #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 27.03% 27.06% +0.03%
==========================================
Files 75 76 +1
Lines 10188 10191 +3
Branches 1345 1345
==========================================
+ Hits 2754 2758 +4
- Misses 7344 7345 +1
+ Partials 90 88 -2 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tieneupin
force-pushed
the
instrument-server-dependencies
branch
from
395b2be to
933cfe6
Compare
stephen-riggs
approved these changes
Jan 15, 2025
tieneupin
changed the title
This was referenced Jan 15, 2025
d-j-hatton
pushed a commit
that referenced
this pull request
Jan 21, 2025
…strument server dependencies (#448) * Moves the `_midpoint()` function to `murfey.util.tomo` to keep client and server modules detached * Replaces remaining instances of `procrunner.run()` with `subprocess.run()` * Creates a new key for instrument server package dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also incorporates changes from PR #447 , which has now been closed as redundant.
_midpoint()function tomurfey.util.tomoto keep client and server modules detachedprocrunner.run()withsubprocess.run()