Resolved client-server interdependence when running a Murfey server#447
Closed
Resolved client-server interdependence when running a Murfey server#447
Conversation
… preserve client-server independence
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 27.03% 27.04% +0.01%
==========================================
Files 75 76 +1
Lines 10188 10190 +2
Branches 1345 1345
==========================================
+ Hits 2754 2756 +2
Misses 7344 7344
Partials 90 90 |
Contributor
Author
|
Closed because it is already being looked at in the newer PR (#448). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves issue #446 .
murfey.client.contexts.tomo._midpointwas imported and used once inmurfey.server.__init__. This causes the modules inmurfey.clientto be initialised, leading to a dependency chain where the client-side dependencies have to be installed just to run the server modules.By duplicating the
_midpointfunction inmurfey.server.__init__, this breaks that import chain.EDIT: A better solution has been to move the
midpoint()function over tomurfey.util.__init__, which breaks that import chain