Skip to content

Resolved client-server interdependence when running a Murfey server#447

Closed
tieneupin wants to merge 2 commits intomainfrom
client-server-disentanglement
Closed

Resolved client-server interdependence when running a Murfey server#447
tieneupin wants to merge 2 commits intomainfrom
client-server-disentanglement

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jan 14, 2025

Partially resolves issue #446 .

murfey.client.contexts.tomo._midpoint was imported and used once in murfey.server.__init__. This causes the modules in murfey.client to be initialised, leading to a dependency chain where the client-side dependencies have to be installed just to run the server modules.

By duplicating the _midpoint function in murfey.server.__init__, this breaks that import chain.

EDIT: A better solution has been to move the midpoint() function over to murfey.util.__init__, which breaks that import chain

@tieneupin tieneupin added bug Something isn't working server Relates to the server component client Relates to the client component dependencies labels Jan 14, 2025
@tieneupin tieneupin requested a review from d-j-hatton January 14, 2025 14:50
@tieneupin tieneupin self-assigned this Jan 14, 2025
@tieneupin tieneupin changed the title Resolved client-server interdependence Resolved client-server interdependence when running a Murfey server Jan 14, 2025
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 27.04%. Comparing base (19f2f31) to head (6988807).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   27.03%   27.04%   +0.01%     
==========================================
  Files          75       76       +1     
  Lines       10188    10190       +2     
  Branches     1345     1345              
==========================================
+ Hits         2754     2756       +2     
  Misses       7344     7344              
  Partials       90       90              

@tieneupin
Copy link
Contributor Author

Closed because it is already being looked at in the newer PR (#448).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working client Relates to the client component dependencies server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant