Skip to content

CI: make actions for testing and publishing the crate #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tomcat-42
Copy link
Contributor

As pointed by @awakecoding, external actions are blocked by the org. Anyway, I'm
pushing this so we can work on refactoring this into a custom GH action.

@Tomcat-42 Tomcat-42 mentioned this pull request Nov 2, 2023
1 task
@CBenoit
Copy link
Member

CBenoit commented Nov 2, 2023

Thank you for that @Tomcat-42!

I think it’s better if we handle the publishing workflow on our side. We already have plans for that, and I’ll apply the workflow to all our open source projects when it’s ready 🙂

However, I’m open to adding a ci.yml workflow for checking PRs automatically. Ideally, I would like something similar to the one we have on picky-rs:

(with minor adjustments, we don’t have ffi or wasm bindings for conan-rs)

It would be useful to specify the minimal supported Rust version as well, so we can check for it:

In order to easily find the msrv, cargo-msrv can be used.

Maybe the lints step will fail for conan-rs, I don’t know if clippy was ran against much. Enabling this job and fixing the lints should be a separate PR if you decide to go for it

@Tomcat-42
Copy link
Contributor Author

I think it’s better if we handle the publishing workflow on our side. We already have plans for that, and I’ll apply the workflow to all our open source projects when it’s ready 🙂

Sure.

However, I’m open to adding a ci.yml workflow for checking PRs automatically. Ideally, I would like something similar to the one we have on picky-rs:

https://github.com/Devolutions/picky-rs/blob/67277e6cc211527aa2bf5da0788f415f2e041409/.github/workflows/ci.yml
(with minor adjustments, we don’t have ffi or wasm bindings for conan-rs)

It would be useful to specify the minimal supported Rust version as well, so we can check for it:

https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
In order to easily find the msrv, cargo-msrv can be used.
Yeah, it would be nice. In the following week, probably I'll work on that.

Maybe the lints step will fail for conan-rs, I don’t know if clippy was ran against much. Enabling this job and fixing the lints should be a separate PR if you decide to go for it

In this too.

@CBenoit
Copy link
Member

CBenoit commented Nov 2, 2023

Thank you, this is very appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants