-
Notifications
You must be signed in to change notification settings - Fork 13
Fix deps include dirs listing #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deps include dirs listing #20
Conversation
@Tomcat-42 I'll look into getting the secret added for the publishing workflow (our DevOps team is busy this week with our major release, so it may go to next week). Is publishing workflow limited to the master branch? We'd need to add a GitHub environment with the secret in, and restrict how it can be used. Ideally we'd still need to trigger the workflow ourselves, on the master branch only |
The publish job should only run on tagged master now |
@Tomcat-42 I'm tagging my @CBenoit - for the publishing workflow, our GitHub organization blocks external GitHub Actions like those used in the current workflow. I know Benoit worked on custom GitHub Actions, but we'd need a bit more time to do this properly with the limitations we have in place. I would suggest splitting the code changes from this pull request so they can be merged quickly, leaving us more time to set up a publishing workflow. |
a661f93
to
b781876
Compare
Ok, I Splited the GH Actions into #21 |
About the |
Thank you @Tomcat-42, FYI the new version is now available on crates.io |
This pull request:
BuildDependency::get_include_dir
returning just the first include dir (some deps have multiple include dirs). I've renamed the method. Fixes BuildDependency with multiple include directories doesn't allow for full usage. #8 .