Khanayan123/add consistent config system tests #3745
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -193,7 +193,7 @@ def test_datadog_128_bit_generation_enabled(self, test_agent, test_library): | |
|
|
||
| @missing_feature(context.library == "golang", reason="not implemented") | ||
| @missing_feature(context.library < "[email protected]", reason="Implemented in 1.24.0") | ||
| @missing_feature(context.library < "nodejs@4.19.0", reason="Implemented in 4.19.0 & 3.40.0") | ||
| @missing_feature(context.library == "ruby", reason="not implemented") | ||
| @pytest.mark.parametrize("library_env", [{"DD_TRACE_PROPAGATION_STYLE": "Datadog"}]) | ||
| def test_datadog_128_bit_generation_enabled_by_default(self, test_agent, test_library): | ||
simon-id marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
@@ -383,6 +383,7 @@ def test_w3c_128_bit_propagation(self, test_agent, test_library): | |
| assert dd_p_tid == "640cfd8d00000000" | ||
| check_128_bit_trace_id(fields[1], trace_id, dd_p_tid) | ||
|
|
||
| @missing_feature(context.library < "[email protected]", reason="implemented in 5.7.0 & 4.31.0") | ||
| @missing_feature(context.library == "ruby", reason="not implemented") | ||
| @pytest.mark.parametrize( | ||
| "library_env", | ||
|
|
@@ -409,8 +410,6 @@ def test_w3c_128_bit_propagation_tid_consistent(self, test_agent, test_library): | |
| assert propagation_error is None | ||
|
|
||
| @missing_feature(context.library == "ruby", reason="not implemented") | ||
| @pytest.mark.parametrize( | ||
| "library_env", | ||
| [{"DD_TRACE_PROPAGATION_STYLE": "tracecontext", "DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED": "true"}], | ||
|
|
@@ -422,6 +421,26 @@ def test_w3c_128_bit_propagation_tid_in_chunk_root(self, test_agent, test_librar | |
| with test_library.dd_start_span(name="child", service="service", parent_id=parent.span_id) as child: | ||
| pass | ||
|
|
||
| traces = test_agent.wait_for_num_traces(1, clear=True, sort_by_start=False) | ||
| trace = find_trace(traces, parent.trace_id) | ||
| assert len(trace) == 2 | ||
| first_span = find_first_span_in_trace_payload(trace) | ||
| tid_chunk_root = first_span["meta"].get("_dd.p.tid") | ||
| assert tid_chunk_root is not None | ||
|
|
||
| @missing_feature(context.library == "ruby", reason="not implemented") | ||
| @missing_feature(context.library == "java", reason="not implemented") | ||
| @pytest.mark.parametrize( | ||
| "library_env", | ||
| [{"DD_TRACE_PROPAGATION_STYLE": "tracecontext", "DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED": "true"}], | ||
|
There was a problem hiding this comment. If There was a problem hiding this comment. The test in the file test_datadog_128_bit_generation_enabled_by_default already verifies that 128-bit generation is enabled by default. Other tests explicitly configure this setting to ensure that other aspects of the feature can be tested, even in scenarios where the language may not enable this functionality by default There was a problem hiding this comment. Hmm.. okay. Like we don't care whether DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED is true by default in this test, we just want to check what the behavior is when it is enabled? I don't think we do that for other tests, but this isn't a blocker, it's fine. Maybe add a comment or something |
||
| ) | ||
| def test_w3c_128_bit_propagation_tid_only_in_chunk_root(self, test_agent, test_library): | ||
| """Ensure that only root span contains the tid.""" | ||
| with test_library: | ||
| with test_library.dd_start_span(name="parent", service="service", resource="resource") as parent: | ||
| with test_library.dd_start_span(name="child", service="service", parent_id=parent.span_id) as child: | ||
| pass | ||
|
|
||
| traces = test_agent.wait_for_num_traces(1, clear=True, sort_by_start=False) | ||
| trace = find_trace(traces, parent.trace_id) | ||
| assert len(trace) == 2 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of missing feature can we use
system-tests/docs/edit/skip-tests.md
Line 5 in 25c79a3