Khanayan123/add consistent config system tests #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanayan123
requested review from
christophe-papazian,
manuel-alvarez-alvarez,
jandro996 and
cataphract
and removed request for
a team
mabdinur
reviewed
Jan 3, 2025
| @@ -241,8 +241,14 @@ tests/: | |||
| Test_Config_HttpServerErrorStatuses_FeatureFlagCustom: missing_feature | |||
| Test_Config_IntegrationEnabled_False: missing_feature | |||
| Test_Config_IntegrationEnabled_True: missing_feature | |||
| Test_Config_LogInjection_128Bit_TradeId_Default: missing_feature | |||
There was a problem hiding this comment.
Instead of missing feature can we use
system-tests/docs/edit/skip-tests.md
Line 5 in 25c79a3
cbeauchesne
reviewed
Jan 3, 2025
khanayan123
force-pushed
the
khanayan123/add-consistent-config-system-tests
branch
from
8553526 to
e954a94
Compare
khanayan123
force-pushed
the
khanayan123/add-consistent-config-system-tests
branch
from
17e1ac1 to
124beee
Compare
mtoffl01
reviewed
Jan 15, 2025
Co-authored-by: Mikayla Toffler <[email protected]>
mtoffl01
reviewed
Jan 15, 2025
Co-authored-by: Mikayla Toffler <[email protected]>
cbeauchesne
requested changes
Jan 16, 2025
|
seems good, just waiting for the CI to finish to approve the PR |
cbeauchesne
approved these changes
Jan 17, 2025
khanayan123
deleted the
khanayan123/add-consistent-config-system-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds new system tests to assert config consistency
Changes
Adds system tests for DD_TRACE_SAMPLING_RULES, DD_LOG_INEJCTION, DD_RUNTIME_METRICS_ENABLED, & DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED, DD_TRACE_AGENT_URL, as per https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit?usp=sharing
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED tests were tested against this PR:
DataDog/dd-trace-js#5021