feat(extensions)!: improve argument handling - #203
Merged
Conversation
wackywendell
force-pushed
the
wendell/extension-argument-handling
branch
from
August 10, 2026 15:32
633f579 to
1d354bb
Compare
wackywendell
force-pushed
the
wendell/extension-argument-handling
branch
4 times, most recently
from
August 12, 2026 19:54
360b355 to
41768ba
Compare
wackywendell
force-pushed
the
wendell/extension-argument-handling
branch
from
August 12, 2026 20:13
41768ba to
3205845
Compare
wackywendell
marked this pull request as ready for review
August 12, 2026 20:14
edouardmulliez
approved these changes
Aug 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the
ExtensionArgsinterface to follow standardOptionusage / naming more closely, for ease of use:Also updates to error handling for extension errors, the addition of
ExtensionValue::Null, and someGRAMMAR.mdupdatesChanges
get_named_orwithget_named::<T>() -> Result<Option<T>, ExtensionError>and renamesexpect_named_argtoexpect_named.Invalid named argument 'count': ....ExtensionValue::Nullfor a present, untypednullextension value. Typed nulls such asnull:i64?remain expressions.ExtensionValue::Error, allowing one malformed field to render as a local failure token without losing later arguments.FetchandCasttoGRAMMAR.md, since they weren't there...API impact
This is a breaking public API change:
get_named_oris removed (in favor ofget_named(...).unwrap_or(...), more standardOptionnaming) andexpect_named_argis renamed toexpect_named.ExtensionValueandExtensionValueKindhave newNullandErrorvariants, which affects exhaustive matches.