refactor(extensions)!: centralize argument extraction - #205
Merged
Conversation
wackywendell
force-pushed
the
wendell/framework-managed-args-extractor
branch
from
August 10, 2026 21:36
c42c288 to
665b375
Compare
wackywendell
force-pushed
the
wendell/framework-managed-args-extractor
branch
from
August 12, 2026 14:39
665b375 to
e72c6d2
Compare
wackywendell
force-pushed
the
wendell/framework-managed-args-extractor
branch
from
August 12, 2026 16:31
e72c6d2 to
12306b6
Compare
wackywendell
force-pushed
the
wendell/framework-managed-args-extractor
branch
from
August 12, 2026 20:13
12306b6 to
0fdd9b3
Compare
wackywendell
force-pushed
the
wendell/framework-managed-args-extractor
branch
2 times, most recently
from
August 13, 2026 18:07
2dcd59b to
1259d88
Compare
wackywendell
force-pushed
the
wendell/framework-managed-args-extractor
branch
from
August 14, 2026 15:36
1259d88 to
a6d4042
Compare
wackywendell
marked this pull request as ready for review
August 14, 2026 15:43
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the interface around
ArgsExtractor, and pushes the assertions around using all arguments (check_exhausted()) out of user code and into the registry conversion.Changes
Explainable::from_argsto receive&mut ArgsAccess<'_>.ExtensionArgs::extractor, publicArgsExtractor::check_exhausted, and the panic-basedDropassertion.positional()mark the complete positional list as handled.output_columns()read-only and outside exhaustion checking because output columns are relation metadata consumed independently by the structural parser.Explainable::to_args(&ExtensionContext)and context-aware relation formatting from feat(extensions)!: Add context to to_args in Explainable trait #202.ArgsExtractoras an optional convenience.API impact
This is a breaking public API change. External
Explainableimplementations must:from_args(&ExtensionArgs)tofrom_args(&mut ArgsExtractor<'_>);check_exhausted()calls.There is intentionally no new public direct-conversion helper. The registry owns the checked decoding boundary.
Validation
cargo test --all-featuresjust check