Skip to content

Allow schema collectors to customize count metric name - #24947

Open
mobuchowski wants to merge 2 commits into
masterfrom
mobuchowski/schema-collector-count-telemetry
Open

Allow schema collectors to customize count metric name#24947
mobuchowski wants to merge 2 commits into
masterfrom
mobuchowski/schema-collector-count-telemetry

Conversation

@mobuchowski

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an overridable object_count_metric_name property to the shared schema collector. Existing collectors retain dd.<dbms>.schema.tables_count by default, while specialized collectors can report a distinct object-count metric.

Motivation

The SQL Server view collector reuses the shared schema collection lifecycle but must report views_count without submitting view rows to the existing table-count metric.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mobuchowski mobuchowski added the qa/skip-qa Automatically skip this PR for the next QA label Aug 21, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 21, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   1 (always emitted)
Diff (2 files):
  datadog_checks_base/changelog.d/24947.fixed
  datadog_checks_base/datadog_checks/base/utils/db/schemas.py

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Aug 21, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.75%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7d94782 | Docs | View more details | Give us feedback!

@mobuchowski
mobuchowski marked this pull request as ready for review August 21, 2026 17:42
@mobuchowski
mobuchowski requested review from a team as code owners August 21, 2026 17:43
@mobuchowski mobuchowski changed the title Allow schema collectors to customize count telemetry Allow schema collectors to count metric name Aug 21, 2026
@mobuchowski mobuchowski changed the title Allow schema collectors to count metric name Allow schema collectors to customize count metric name Aug 21, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant