Collect PostgreSQL view schema metadata - #24972
Draft
mobuchowski wants to merge 4 commits into
Draft
Conversation
|
evalya-impact-summaryevalya impact analysis |
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a dedicated PostgreSQL view collector that runs alongside table schema collection and emits a separate
pg_viewsDBM metadata payload. Each schema contains an emptytablesarray and a populatedviewsarray. Regular and materialized views include their ID, name, owner, reconstructed definition, relation kind, and table-compatible column metadata.Adds
collect_views, enabled by default, and an independentmax_viewslimit of 1000. Existingpg_databasescollection, table queries, filters, and connection handling remain unchanged. View counts are reported asdd.postgres.schema.views_count.Shared telemetry dependency: #24947
Companion backend change: https://github.com/ddoghq/dd-go/pull/12199
Motivation
PostgreSQL schema collection currently discovers only ordinary, partitioned, and foreign tables. UGP needs regular and materialized view definitions and projected columns without treating those objects as physical tables or applying the table limit to them.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged