Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAASINT-3635] DDS: Symantec VIP: Crawler Integration v1.0.0 #19414

Merged
merged 12 commits into from
Mar 7, 2025
Merged

[SAASINT-3635] DDS: Symantec VIP: Crawler Integration v1.0.0 #19414

merged 12 commits into from
Mar 7, 2025

Conversation

surabhipatel-crest
Copy link
Contributor

What does this PR do?

This is an initial release PR of Symantec VIP integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • Pipeline and Facet groups created for this integration are available in our sandbox and will be shared separately with the required teams.
  • Samples for the pipeline review would also be shared separately with the required teams.
  • OOTB detection rules JSON would be shared separately with the required teams as a part of the separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@gunterd gunterd mentioned this pull request Feb 6, 2025
Merged
3 tasks
@torosmassa torosmassa marked this pull request as ready for review February 10, 2025 14:22
@torosmassa torosmassa requested review from a team as code owners February 10, 2025 14:22
@torosmassa torosmassa requested a review from a team February 10, 2025 14:22
@torosmassa torosmassa requested review from a team as code owners February 10, 2025 14:22
@torosmassa torosmassa changed the title DDS: Symantec VIP: Crawler Integration v1.0.0 [SAASINT-3635] DDS: Symantec VIP: Crawler Integration v1.0.0 Feb 10, 2025
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review from a docs team editor label Feb 10, 2025
aliciascott
aliciascott requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @surabhipatel-crest thanks for the addition ! I have a few suggestions mostly for wording and formatting, please request another re-review once updated, thanks!

symantec_vip/README.md Outdated

## Overview

This check monitors [symantec-vip][1].
[Symantec VIP][1] (Validation and ID Protection Service) is a user-friendly, leading cloud-based strong authentication service that enables enterprises to secure access to networks and applications without impacting productivity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Symantec VIP][1] (Validation and ID Protection Service) is a user-friendly, leading cloud-based strong authentication service that enables enterprises to secure access to networks and applications without impacting productivity.
[Symantec VIP][1] (Validation and ID Protection Service) is a cloud-based authentication service that helps enterprises secure access to networks and applications while maintaining productivity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated
### Installation
### Generate API credentials in Symantec VIP

- Obtaining VIP certificate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Obtaining VIP certificate
**Obtaining VIP certificate**:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated
### Generate API credentials in Symantec VIP

- Obtaining VIP certificate
- Please follow the steps mentioned in the official documentation: [Obtaining VIP certificate][2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Please follow the steps mentioned in the official documentation: [Obtaining VIP certificate][2]
Follow the steps in the official documentation: [Obtaining VIP certificate.][2]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated

The symantec-vip check is included in the [Datadog Agent][2] package.
No additional installation is needed on your server.
- Activating the VIP Report Streaming Service using VIP Certificate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Activating the VIP Report Streaming Service using VIP Certificate
**Activating the VIP Report Streaming Service using VIP Certificate**:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated
The symantec-vip check is included in the [Datadog Agent][2] package.
No additional installation is needed on your server.
- Activating the VIP Report Streaming Service using VIP Certificate
- Before integrating the VIP Report Streaming Service, you must enable the service with Symantec. Contact your Symantec representative to enable the service. Once the service is enabled, activate the VIP Report Streaming Service for your VIP account using the activate API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Before integrating the VIP Report Streaming Service, you must enable the service with Symantec. Contact your Symantec representative to enable the service. Once the service is enabled, activate the VIP Report Streaming Service for your VIP account using the activate API.
- Before integrating the VIP Report Streaming Service, you must enable the service with Symantec. Contact your Symantec representative to enable the service. Once the service is enabled, activate the VIP Report Streaming Service for your VIP account using the activate API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated
No additional installation is needed on your server.
- Activating the VIP Report Streaming Service using VIP Certificate
- Before integrating the VIP Report Streaming Service, you must enable the service with Symantec. Contact your Symantec representative to enable the service. Once the service is enabled, activate the VIP Report Streaming Service for your VIP account using the activate API.
- Please follow steps mentioned in the official documentation to activate API: [Activate VIP Report Streaming Service][3]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Please follow steps mentioned in the official documentation to activate API: [Activate VIP Report Streaming Service][3]
- Follow the steps mentioned in the official documentation to activate API: [Activate VIP Report Streaming Service.][3]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated

### Configuration
- Jurisdiction hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Jurisdiction hash
- **Jurisdiction hash**:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

symantec_vip/README.md Outdated

### Configuration
- Jurisdiction hash
- The jurisdiction hash of the user account is available on the **Account Information** tab of the **Account** page in VIP Manager.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The jurisdiction hash of the user account is available on the **Account Information** tab of the **Account** page in VIP Manager.
The jurisdiction hash of the user account is available on the **Account Information** tab of the **Account** page in VIP Manager.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@shubhamvekariya-crest
Copy link
Contributor

Hi @surabhipatel-crest thanks for the addition ! I have a few suggestions mostly for wording and formatting, please request another re-review once updated, thanks!

Hey @aliciascott, I have addressed the PR comments as Surbhi is on PTO. Could you please re-review?

aliciascott
aliciascott approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, approved for docs, will wait for product reviews

@BoyangHuang BoyangHuang added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Feb 18, 2025
@gunterd gunterd added this pull request to the merge queue Mar 7, 2025
Merged via the queue into DataDog:master with commit bfe2447 Mar 7, 2025
40 of 41 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
@github-merge-queue @shubhamvekariya-crest
[SAASINT-3635] DDS: Symantec VIP: Crawler Integration v1.0.0 (#19414)
79bc7f0 
* Add Symantec VIP integration with assets

* Fixed pipeline suggetion

* Fixed pipeline suggetion for source

* Fixed pipeline suggetion for sample

* Fixed pipeline suggestion for readme

* Update dashboard, pipeline and image

* Resolve CI failure

* Address review comments

---------

Co-authored-by: Shubham Vekariya <[email protected]>
Co-authored-by: shubhamvekariya-crest <[email protected]>
Co-authored-by: Alicia Scott <[email protected]> bfe2447
@shubhamvekariya-crest shubhamvekariya-crest deleted the symantec-vip-assets-v1.0.0 branch April 10, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamvekariya-crest shubhamvekariya-crest shubhamvekariya-crest left review comments

@BoyangHuang BoyangHuang BoyangHuang approved these changes

@aliciascott aliciascott aliciascott approved these changes

Assignees
No one assigned
Labels
assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging docs/approved ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@surabhipatel-crest @shubhamvekariya-crest @BoyangHuang @aliciascott @jhgilbert @gunterd