Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAASINT-3634] DDS: Symantec VIP: Crawler Integration Without Assets #19409

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

surabhipatel-crest
Copy link
Contributor

What does this PR do?

PR includes skeleton of Symantec VIP integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. We will raise separate PR with assets and all necessary information once this PR has been merged.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (724567b) to head (76fad6f).
Report is 140 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@surabhipatel-crest surabhipatel-crest changed the title DDS: Symantec VIP: Crawler Integration Without Assets [SAASINT-3634] DDS: Symantec VIP: Crawler Integration Without Assets Jan 22, 2025
HadhemiDD
HadhemiDD previously approved these changes Jan 24, 2025
@gunterd
Copy link
Contributor

gunterd commented Feb 5, 2025

Can you please add the following to CODEOWNERS?

/symantec_vip/                                                        @DataDog/saas-integrations
/symantec_vip/*.md                                                    @DataDog/saas-integrations @DataDog/documentation
/symantec_vip/manifest.json                                           @DataDog/saas-integrations @DataDog/documentation
/symantec_vip/assets/logs/                                            @DataDog/saas-integrations @DataDog/documentation @DataDog/logs-backend

@shubhamvekariya-crest
Copy link
Contributor

shubhamvekariya-crest commented Feb 6, 2025

Can you please add the following to CODEOWNERS?

/symantec_vip/                                                        @DataDog/saas-integrations
/symantec_vip/*.md                                                    @DataDog/saas-integrations @DataDog/documentation
/symantec_vip/manifest.json                                           @DataDog/saas-integrations @DataDog/documentation
/symantec_vip/assets/logs/                                            @DataDog/saas-integrations @DataDog/documentation @DataDog/logs-backend

Hi @gunterd, We have seen duplication in CODEOWNERS file once both the PRs(assets and no-assets) are merged. To avoid this duplication, we decided to keep CODEOWNERS file changes only in assets PR. We can also consider an alternative approach if needed. Please provide your thoughts on this.

@gunterd
Copy link
Contributor

gunterd commented Feb 6, 2025

I don't see the codeowners changes in the assets PR: #19414

@shubhamvekariya-crest shubhamvekariya-crest requested a review from a team as a code owner February 7, 2025 10:23
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed HadhemiDD’s stale review February 7, 2025 10:23

Review from HadhemiDD is dismissed.
Related teams and files:

  • agent-integrations
    • .github/CODEOWNERS
@shubhamvekariya-crest
Copy link
Contributor

We can also consider an alternative approach if needed. Please provide your thoughts on this

Hi @gunterd, Apologies. We have added it to the CODEOWNERS file in this PR. We will define an approach for whether to include it in a no-asset PR or an asset PR. Going forward, we will maintain consistency with the chosen approach.

@gunterd gunterd added this pull request to the merge queue Feb 7, 2025
Merged via the queue into DataDog:master with commit 3e93df0 Feb 7, 2025
29 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
…19409)

* Add Symantec VIP crawler integration without assets

* Update codeowners file

---------

Co-authored-by: Shubham Vekariya <[email protected]>
Co-authored-by: shubhamvekariya-crest <[email protected]> 3e93df0
@shubhamvekariya-crest shubhamvekariya-crest deleted the symantec-vip-v1.0.0 branch April 10, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants