-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAASINT-3634] DDS: Symantec VIP: Crawler Integration Without Assets #19409
[SAASINT-3634] DDS: Symantec VIP: Crawler Integration Without Assets #19409
Conversation
Can you please add the following to CODEOWNERS?
|
Hi @gunterd, We have seen duplication in CODEOWNERS file once both the PRs(assets and no-assets) are merged. To avoid this duplication, we decided to keep CODEOWNERS file changes only in assets PR. We can also consider an alternative approach if needed. Please provide your thoughts on this. |
I don't see the codeowners changes in the assets PR: #19414 |
Review from HadhemiDD is dismissed.
Related teams and files:
- agent-integrations
- .github/CODEOWNERS
Hi @gunterd, Apologies. We have added it to the CODEOWNERS file in this PR. We will define an approach for whether to include it in a no-asset PR or an asset PR. Going forward, we will maintain consistency with the chosen approach. |
…19409) * Add Symantec VIP crawler integration without assets * Update codeowners file --------- Co-authored-by: Shubham Vekariya <[email protected]> Co-authored-by: shubhamvekariya-crest <[email protected]> 3e93df0
What does this PR do?
PR includes skeleton of Symantec VIP integration without any assets like dashboards, image, README content, etc.
Motivation
This is beta release of crawler integration and is intended for internal testing before going live. We will raise separate PR with assets and all necessary information once this PR has been merged.
Additional Notes
Only crawler-based integration related changes are included in this PR.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged